Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1391)

Issue 2130041: Common container updates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by mhermanto
Modified:
13 years, 5 months ago
Reviewers:
zhoresh, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

- Reduce the response size, by filtering the fields needed. - Prioritize initial iframe size to: requested size, view-specified size, moduleprefs-specified size, default. - Allow disabling of security token update by setting it to -1. - gadgets.rpc.call to update_security_token now only work if there is 1+ gadgets receiving it. This avoids warning of rpc service not found. - Make most (not all yet) JSON keys constants.

Patch Set 1 : Update patch #

Total comments: 2

Patch Set 2 : Update patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -164 lines) Patch
features/src/main/javascript/features/container/constant.js View 1 1 chunk +75 lines, -0 lines 0 comments Download
features/src/main/javascript/features/container/container.js View 9 chunks +49 lines, -32 lines 0 comments Download
features/src/main/javascript/features/container/feature.xml View 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/container/gadget_holder.js View 10 chunks +32 lines, -38 lines 0 comments Download
features/src/main/javascript/features/container/gadget_site.js View 1 15 chunks +78 lines, -54 lines 0 comments Download
features/src/main/javascript/features/container/service.js View 5 chunks +2 lines, -26 lines 0 comments Download
features/src/main/javascript/features/container/util.js View 2 chunks +41 lines, -6 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java View 1 chunk +1 line, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java View 2 chunks +11 lines, -4 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeProcessor.java View 3 chunks +10 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetHandlerServiceTest.java View 6 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mhermanto
13 years, 7 months ago (2010-09-01 22:26:38 UTC) #1
zhoresh
lgtm suggestions inlined http://codereview.appspot.com/2130041/diff/7002/features/src/main/javascript/features/container/gadget_site.js File features/src/main/javascript/features/container/gadget_site.js (right): http://codereview.appspot.com/2130041/diff/7002/features/src/main/javascript/features/container/gadget_site.js#newcode251 features/src/main/javascript/features/container/gadget_site.js:251: || viewParams['view'] Add constants for viewParams? ...
13 years, 6 months ago (2010-09-10 22:02:11 UTC) #2
mhermanto
On Fri, Sep 10, 2010 at 3:02 PM, <zhoresh@gmail.com> wrote: > lgtm > > suggestions ...
13 years, 6 months ago (2010-09-13 17:08:39 UTC) #3
mhermanto
Update patch
13 years, 6 months ago (2010-09-13 17:17:35 UTC) #4
zhoresh
13 years, 6 months ago (2010-09-13 17:41:03 UTC) #5
lgtm, Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b