Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(616)

Issue 21280043: A \score-lines markup list command for multi-lines embedded scores (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

A \score-lines markup list command for multi-lines embedded scores Originally requested as issue 1334. Like the \score markup, \score-lines is not called through the normal markup list command mechanisms as it would require something awkward along the lines of \score-lines ##{ \score { ... } #} to get this through. Instead, a reserved word \score-lines in the parser will manually call the command with an embedded score, leading to just \score-lines { ... } This is somewhat clumsy in several ways: it requires an additional reserved identifier (no other reserved identifier contains a dash), and it means that a score may occur in a file without an explicit enclosing \score command. Nevertheless, the previous semantics implemented as issue 1334 were not tenable: particularly after issue 3270 had been passed, it was close to impossible for the average user to come up with a way of getting an actual markup list from a score. Note that there are as of yet no user-level commands spacing a markup list in a way similar to the spacing inside of a \score markup.

Patch Set 1 #

Total comments: 2

Patch Set 2 : doc string, regtest, make it actually work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -27 lines) Patch
A input/regression/score-lines.ly View 1 1 chunk +40 lines, -0 lines 0 comments Download
M lily/lexer.ll View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lily/parser.yy View 7 chunks +13 lines, -20 lines 0 comments Download
M scm/define-markup-commands.scm View 1 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 3
lemzwerg
https://codereview.appspot.com/21280043/diff/1/lily/lily-lexer.cc File lily/lily-lexer.cc (right): https://codereview.appspot.com/21280043/diff/1/lily/lily-lexer.cc#newcode79 lily/lily-lexer.cc:79: {"score-lines", SCORELINES}, If the dash in `score-lines' is problematic ...
10 years, 6 months ago (2013-11-03 08:56:47 UTC) #1
dak
https://codereview.appspot.com/21280043/diff/1/lily/lily-lexer.cc File lily/lily-lexer.cc (right): https://codereview.appspot.com/21280043/diff/1/lily/lily-lexer.cc#newcode79 lily/lily-lexer.cc:79: {"score-lines", SCORELINES}, On 2013/11/03 08:56:47, lemzwerg wrote: > If ...
10 years, 6 months ago (2013-11-03 09:34:56 UTC) #2
dak
10 years, 5 months ago (2013-11-08 14:16:26 UTC) #3
doc string, regtest, make it actually work
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b