Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6118)

Issue 2122047: Move the log handler code from bus/main.cc to src/ibusshare.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by satorux
Modified:
13 years, 7 months ago
Reviewers:
Peng Huang
Base URL:
git@github.com:ibus/ibus.git
Visibility:
Public.

Description

Move the log handler code from bus/main.cc to src/ibusshare.cc. The log handler is useful for IBus client programs. For instance, the log handler was used inside the chromium browser for debugging IBus startup issue: http://code.google.com/p/chromium-os/issues/detail?id=6375#c29 (chrome:11824): IBUS-DEBUG: 00:00:46.929430: The socket file is now created (monitoring done). BUG=none TEST=manually ran ibus-daemon with and without -v

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Patch Set 3 : address comments #

Patch Set 4 : reworked #

Patch Set 5 : use & #

Patch Set 6 : rewrote comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -30 lines) Patch
M bus/main.c View 3 chunks +1 line, -30 lines 0 comments Download
M src/ibusshare.h View 1 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
M src/ibusshare.c View 1 3 4 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6
satorux
13 years, 7 months ago (2010-09-08 07:48:02 UTC) #1
Peng Huang
http://codereview.appspot.com/2122047/diff/1/src/ibusshare.c File src/ibusshare.c (right): http://codereview.appspot.com/2122047/diff/1/src/ibusshare.c#newcode2 src/ibusshare.c:2: /* vim:set et sts=4: */ Does this work for ...
13 years, 7 months ago (2010-09-08 07:56:22 UTC) #2
satorux
http://codereview.appspot.com/2122047/diff/1/src/ibusshare.c File src/ibusshare.c (right): http://codereview.appspot.com/2122047/diff/1/src/ibusshare.c#newcode2 src/ibusshare.c:2: /* vim:set et sts=4: */ On 2010/09/08 07:56:22, Peng ...
13 years, 7 months ago (2010-09-08 08:11:12 UTC) #3
Peng Huang
LGTM
13 years, 7 months ago (2010-09-08 08:17:15 UTC) #4
satorux
As chatted offline, reworked the logic. please take another look On 2010/09/08 08:17:15, Peng Huang ...
13 years, 7 months ago (2010-09-08 09:08:51 UTC) #5
Peng Huang
13 years, 7 months ago (2010-09-08 09:42:15 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b