Replaced raw pointers to RefCountObject to BindingPointer....

Replaced raw pointers to RefCountObject to BindingPointer.

This fixes the ANGLE crashes in Chrome when using canvas 2D.

The issue was this:

Renderbuffer *mColorbufferProxy = new RenderBuffer(...); // Reference count is zero.

BindingPointer<RenderBuffer> tempRef;
tempRef.set(mColorbufferProxy); // Reference count is one.

tempRef.set(NULL); // Reference count is zero and object is destroyed, leaving mColorbufferProxy dangling.

I also initially suspected the problem was that FBOs are not treated as shared and the implementation of shared FBOs is still in the patch. I believe GLES2 supports shared FBOs.

My reading of the GLES2 spec is that when a shared object is deleted, it loses its id but retains its state if left bound elsewhere. I added that to RefCountObject.

[apatrick1, 2010-09-11 01:35:06]

I think this resolves our outstanding ANGLE issues. Can you review?

Thanks,

Al

[vangelis, 2010-09-11 02:09:05]

This looks reasonable to me.  Al, please check it in so that we can give it a
try. Daniel, if you have any objections, please feel free to back it out.

On 2010/09/11 01:35:06, apatrick1 wrote:
> I think this resolves our outstanding ANGLE issues. Can you review?
> 
> Thanks,
> 
> Al