Issue 2108047: Changed raw pointers to RefCountObject to BindingPointers....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2108047: Changed raw pointers to RefCountObject to BindingPointers....

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by apatrick1

Modified:
13 years, 7 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changed raw pointers to RefCountObject to BindingPointers. I suspect there is a bug whereby an owning reference to a RefCountObject is temporarily assigned to a BindingPointer, causing it to be destroyed and making the owning raw pointer go dangling. Making this change for mColorbufferProxy seemed to fix a crash in Chrome with canvas 2D. This was previously landed in r417 and r418.

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -42 lines)			Patch
M	src/libGLESv2/Context.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/libGLESv2/Context.cpp	View	9 chunks	+11 lines, -19 lines	0 comments	Download
M	src/libGLESv2/Texture.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Texture.cpp	View	4 chunks	+8 lines, -16 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

Here's the first patch. I wrote it against r416 so it should be easier to ...

13 years, 8 months ago (2010-09-13 22:07:43 UTC) #1

dgkoch

13 years, 7 months ago (2010-09-14 04:11:35 UTC) #2

Ah, I think I understand this now.  I suspect the bug was because Texture.cpp
had an explicit mColorbufferProxy->addRef(), but there was no corresponding
Release call. 

In any case, I think this is a good change. 

Approved.

Expand All Messages | Collapse All Messages