Issue 206044: code review 206044: make units compile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 206044: code review 206044: make units compile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 4 months ago by fhs

Modified:
16 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

make units compile

Patch Set 1 #

Patch Set 2 : code review 206044: make units compile #

Created: 16 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/goyacc/units.y	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fhs

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

16 years, 4 months ago (2010-02-09 05:49:46 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=a04231b12d37 *** make units compile R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/206044 Committer: Russ Cox ...

16 years, 4 months ago (2010-02-09 21:20:24 UTC) #2

LGTM

Expand All Messages | Collapse All Messages