Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(841)

Issue 205043: array assign can nuke derivatives (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by ckulla
Modified:
14 years, 2 months ago
Reviewers:
osl-dev, dev-osl, clifford.stein, aconty
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Array assignment was incorrectly clearing the derivatives of all entries instead of just the derivatives of the entry being assigned.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
src/liboslexec/oparray.cpp View 3 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 4
ckulla
14 years, 2 months ago (2010-02-08 19:54:50 UTC) #1
ckulla
On 2010/02/08 19:54:50, ckulla wrote: > Any comments on this?
14 years, 2 months ago (2010-02-09 21:40:51 UTC) #2
clifford.stein
On 2010/02/09 21:40:51, ckulla wrote: > On 2010/02/08 19:54:50, ckulla wrote: > > > > ...
14 years, 2 months ago (2010-02-09 21:55:56 UTC) #3
aconty
14 years, 2 months ago (2010-02-09 21:57:23 UTC) #4
LGTM2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b