Issue 2045041: [BugFix]: Followup change to pass on container information correctly in all CajaCssSanitizer usages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2045041: [BugFix]: Followup change to pass on container information correctly in all CajaCssSanitizer usages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by gagan.goku

Modified:
15 years, 4 months ago

Reviewers:
Paul Lindner, dev, mhermanto, zhoresh, jcian

CC:
cool-shindig-committers_googlegroups.com, anupama.dutta

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This is a followup change (following already committed change http://codereview.appspot.com/2004042/). The goal is to pass on the correct gadget context (which includes container) throughout the path of request serving. Current CajaCssSanitizer does not make use of the current gadget container information because it is using only the url of the resource to be proxied for generating the proxy uri. This change passes the gadgetContext all the way so that the correct container can be used to generate the proxy uri.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -56 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java	View		7 chunks	+21 lines, -15 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingResponseRewriter.java	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizerTest.java	View	1	5 chunks	+85 lines, -22 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriterTest.java	View		6 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

anupama.dutta

Neat change with good tests :) LGTM. Please send to dev@, jcian@, zhoresh@, lindner@ for ...

15 years, 4 months ago (2010-08-27 13:45:45 UTC) #2

gagan.goku

On 2010/08/27 13:45:45, anupama.dutta wrote: > Neat change with good tests :) > LGTM. > ...

15 years, 4 months ago (2010-08-27 15:24:37 UTC) #3

jcian

On 2010/08/27 13:45:45, anupama.dutta wrote: > Neat change with good tests :) > LGTM. > ...

15 years, 4 months ago (2010-08-27 16:05:49 UTC) #4

Paul Lindner

committed On 2010/08/27 16:05:49, jcian wrote: > On 2010/08/27 13:45:45, anupama.dutta wrote: > > Neat ...

15 years, 4 months ago (2010-08-27 21:01:47 UTC) #5

gagan.goku

15 years, 4 months ago (2010-08-28 02:05:00 UTC) #6

Thanks Paul.

On Sat, Aug 28, 2010 at 2:31 AM, <lindner@inuus.com> wrote:

> committed
>
>
> On 2010/08/27 16:05:49, jcian wrote:
>
>> On 2010/08/27 13:45:45, anupama.dutta wrote:
>> > Neat change with good tests :)
>> > LGTM.
>> > Please send to dev@, jcian@, zhoresh@, lindner@ for commit/review.
>>
>
>  LGTM too.
>>
>
>
>
> http://codereview.appspot.com/2045041/
>

Expand All Messages | Collapse All Messages