Replaces swap chain lazily when the swap interval is changed....

Replaces swap chain lazily when the swap interval is changed.

It does not appear to be possible to pass a presentation interval to Present() or change it after creating the swap chain, short of calling Reset(). I decided to try fixing it by replacing the swap chain under the same conditions as a window resize.

I tested it with a modified version of the simple vertex shader sample, passing various values to eglSwapInterval.

My reading of the EGL spec might be wrong but I believe the interval state should be associated with the surface bound to the current context, rather than the display.

[apatrick1, 2010-08-31 00:40:10]

Daniel,

I think I found a bug in eglSwapInterval. Can you take a look at this fix?

Thanks,

Al

[dgkoch, 2010-08-31 13:34:53]

Hi Al, 

I concur with your assessment.  Your changes look good, my only comments are
more stylistic.

Daniel

http://codereview.appspot.com/2036044/diff/2001/3001
File src/libEGL/Display.cpp (right):

http://codereview.appspot.com/2036044/diff/2001/3001#newcode334
src/libEGL/Display.cpp:334: presentParameters.PresentationInterval =
convertInterval(mMinSwapInterval);
If you move convertInterval() to Surface.cpp you could just use
D3DPRESENT_INTERVAL_DEFAULT here (since this swap chain is never used anyhow).

http://codereview.appspot.com/2036044/diff/2001/3001#newcode442
src/libEGL/Display.cpp:442: DWORD Display::convertInterval(GLint interval)
I might suggest moving convertInterval to Surface.cpp, since that is where the
primary use of it is a this point (not that it even needs to be a member
function, but we haven't added a utility file in EGL yet).

http://codereview.appspot.com/2036044/diff/2001/3003
File src/libEGL/Surface.cpp (right):

http://codereview.appspot.com/2036044/diff/2001/3003#newcode317
src/libEGL/Surface.cpp:317: bool Surface::checkForWindowResize()
checkForWindowResize is starting to sound like the wrong name for this
function... :-)

[apatrick1, 2010-08-31 18:40:09]

Thanks for the feedback. Fixes uploaded.

Al

[dgkoch, 2010-08-31 18:45:40]

looks good.

Daniel