Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14898)

Issue 203090043: Make Grob::name accessible to Scheme

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by david.nalesnik
Modified:
9 years, 2 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Make Grob::name accessible to Scheme Needing to determine the name of a grob is extremely common to users of Scheme.

Patch Set 1 #

Patch Set 2 : return a symbol #

Patch Set 3 : rewrite in Scheme #

Patch Set 4 : restore docstring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M scm/output-lib.scm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8
david.nalesnik
Please review. Thanks!
9 years, 2 months ago (2015-02-15 19:54:19 UTC) #1
dak
On 2015/02/15 19:54:19, david.nalesnik wrote: > Please review. Thanks! "Needing to determine the name of ...
9 years, 2 months ago (2015-02-16 07:56:10 UTC) #2
david.nalesnik
On 2015/02/16 07:56:10, dak wrote: > On 2015/02/15 19:54:19, david.nalesnik wrote: > > Please review. ...
9 years, 2 months ago (2015-02-16 13:46:29 UTC) #3
dak
On 2015/02/16 13:46:29, david.nalesnik wrote: > On 2015/02/16 07:56:10, dak wrote: > > On 2015/02/15 ...
9 years, 2 months ago (2015-02-16 14:05:46 UTC) #4
david.nalesnik
Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should ...
9 years, 2 months ago (2015-02-18 19:32:57 UTC) #5
david.nalesnik
On 2015/02/18 19:32:57, david.nalesnik wrote: > Hmmm. Since this is no longer just a wrapper ...
9 years, 2 months ago (2015-02-18 20:46:03 UTC) #6
david.nalesnik
On 2015/02/18 20:46:03, david.nalesnik wrote: > On 2015/02/18 19:32:57, david.nalesnik wrote: > > Hmmm. Since ...
9 years, 2 months ago (2015-02-19 16:53:54 UTC) #7
david.nalesnik
9 years, 2 months ago (2015-02-19 17:00:20 UTC) #8
And in a few moments a version where I didn't strip the docstring...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b