Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 201520044: Patch for issue 3882: stencils with stroke-thickness set to zero

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by luk.pietsch
Modified:
9 years ago
Reviewers:
pkx166h, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Patch for issue 3882: stencils with stroke-thickness set to zero Bring PS output in line with SVG output, so that it becomes possible to define path stencil expressions with a filled contour but no outline stroke. (This is necessary for consistent support of user-defined glyphs defined as path stencils, to be used for planned mensural notation extensions)

Patch Set 1 #

Total comments: 1

Patch Set 2 : more efficient statement of conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M scm/output-ps.scm View 1 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 9
dak
https://codereview.appspot.com/201520044/diff/1/scm/output-ps.scm File scm/output-ps.scm (right): https://codereview.appspot.com/201520044/diff/1/scm/output-ps.scm#newcode308 scm/output-ps.scm:308: (if (or (not fill?)(> thickness 0)) "gsave stroke grestore" ...
9 years, 1 month ago (2015-02-25 20:25:25 UTC) #1
luk.pietsch
On 2015/02/25 20:25:25, dak wrote: > That sounds like unnecessary effort in some cases. How ...
9 years, 1 month ago (2015-02-25 23:04:14 UTC) #2
luk.pietsch
more efficient statement of conditional
9 years, 1 month ago (2015-02-26 16:56:55 UTC) #3
pkx166h
Patchy the autobot says: passes tests. Includes a full make doc
9 years, 1 month ago (2015-02-28 16:59:53 UTC) #4
pkx166h
Lukas, It seems to me that from the email thread on the lists this patch ...
9 years ago (2015-03-03 18:34:24 UTC) #5
luk.pietsch
On 2015/03/03 18:34:24, J_lowe wrote: > It seems to me that from the email thread ...
9 years ago (2015-03-03 18:53:18 UTC) #6
pkx166h
On 2015/03/03 18:53:18, luk.pietsch wrote: > On 2015/03/03 18:34:24, J_lowe wrote: > > It seems ...
9 years ago (2015-03-04 10:49:06 UTC) #7
pkx166h
Patch counted down - please push
9 years ago (2015-03-06 08:16:15 UTC) #8
pkx166h
9 years ago (2015-03-08 10:42:18 UTC) #9
author	Lukas Pietsch <lukas.pietsch@freenet.de>	
	Sun, 8 Mar 2015 10:34:32 +0000 (10:34 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 8 Mar 2015 10:39:06 +0000 (10:39 +0000)
commit	b7fdbfc2ceb805cfca5b386b43e1dec831702b17

(I downloaded the diff file from Rietveld and applied that way).

This issue can be closed now.

Thanks Lukas.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b