Issue 20085: Addressing http://framework.zend.com/issues/browse/ZF-1920

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20085: Addressing http://framework.zend.com/issues/browse/ZF-1920 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by api.jhartmann-google

Modified:
14 years, 9 months ago

Reviewers:
Trevor Johns (Google)

CC:
rboyd

Base URL:
http://framework.zend.com/svn/framework/standard/trunk

Visibility:
Public.

Description

http://framework.zend.com/issues/browse/ZF-1920

Patch Set 1 #

Patch Set 2 : Updated #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
		ClientLogin.php	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

api.jhartmann-google

I can't figure out why we create a new client here. Seems unnecessary... - J

15 years, 2 months ago (2009-02-27 00:49:47 UTC) #1

api.jhartmann-google

Not sure what's going on with SVN on ZF's site but I get 404s... Here ...

15 years, 2 months ago (2009-02-27 19:15:48 UTC) #2

Trevor Johns (Google)

15 years, 1 month ago (2009-03-03 00:15:54 UTC) #3

On 2009/02/27 19:15:48, api.jhartmann wrote:
> Not sure what's going on with SVN on ZF's site but I get 404s...
> 
> Here is another patch that addresses issues in the first one, namely: 
> 
> - typo in the date (not sure how that happened...)
> - removed (instead of commented out) the line that creates a new client
> 
> Note that I ran AllTests and no new failures were introduced with this
change...

LGTM.

Expand All Messages | Collapse All Messages