T1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to documents (NR).

T1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to documents (NR).

[Graham Percival (old account), 2010-08-16 09:31:23]

Looks mostly good.

http://codereview.appspot.com/2004041/diff/1/2
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/2004041/diff/1/2#newcode110
Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf} (or
@file{fandangoforelephants.png},
or .eps, or .ps, or .svg... just mention .pdf.  Anybody doing weird stuff will
know what you mean.

http://codereview.appspot.com/2004041/diff/1/2#newcode114
Documentation/notation/input.itely:114: must explicitly code a @code{\book}
block.
what?  Am I missing something here?  This sounds completely wrong.

LATER EDIT: err, ok, the comment about lilypond-book was related to producing
multiple scores in one book.  But that only refers to that particular context;
you can use lilypond-book without writing any explicit \book blocks.  I do that
all the time.

Please revert this change.

http://codereview.appspot.com/2004041/diff/1/2#newcode422
Documentation/notation/input.itely:422: This behaviour can be changed by setting
the variable
Sorry, the doc policy explicitly calls for American spelling.  Please revert
this change.

[Ian Hulin, 2010-08-16 13:48:59]

http://codereview.appspot.com/2004041/diff/1/2
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/2004041/diff/1/2#newcode110
Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf} (or
@file{fandangoforelephants.png},
On 2010/08/16 09:31:24, Graham Percival wrote:
> or .eps, or .ps, or .svg... just mention .pdf.  Anybody doing weird stuff will
> know what you mean.

Done.

http://codereview.appspot.com/2004041/diff/1/2#newcode114
Documentation/notation/input.itely:114: must explicitly code a @code{\book}
block.
On 2010/08/16 09:31:24, Graham Percival wrote:
> what?  Am I missing something here?  This sounds completely wrong.
> 
> LATER EDIT: err, ok, the comment about lilypond-book was related to producing
> multiple scores in one book.  But that only refers to that particular context;
> you can use lilypond-book without writing any explicit \book blocks.  I do
that
> all the time.
> 
> Please revert this change.

Paragraph removed.

http://codereview.appspot.com/2004041/diff/1/2#newcode422
Documentation/notation/input.itely:422: This behaviour can be changed by setting
the variable
On 2010/08/16 09:31:24, Graham Percival wrote:
> Sorry, the doc policy explicitly calls for American spelling.  Please revert
> this change.

Under protest.
The doc policy sucks. 
Webster was a dyslexic (ask any non-American chemist about element Al).

[Graham Percival, 2010-08-16 14:32:59]

Looks good to me.  Could you send me the patch (privately) so I can
push it correctly attributed to you?

David: yes, I've already complained about Rietveld's atrocious lack of
the real patch file.

Cheers,
- Graham


On Mon, Aug 16, 2010 at 2:48 PM,  <ian@hulin.org.uk> wrote:
> Reviewers: Graham Percival,
>
>
> http://codereview.appspot.com/2004041/diff/1/2
> File Documentation/notation/input.itely (right):
>
> http://codereview.appspot.com/2004041/diff/1/2#newcode110
> Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf}
> (or @file{fandangoforelephants.png},
> On 2010/08/16 09:31:24, Graham Percival wrote:
>>
>> or .eps, or .ps, or .svg... just mention .pdf.  Anybody doing weird
>
> stuff will
>>
>> know what you mean.
>
> Done.
>
> http://codereview.appspot.com/2004041/diff/1/2#newcode114
> Documentation/notation/input.itely:114: must explicitly code a
> @code{\book} block.
> On 2010/08/16 09:31:24, Graham Percival wrote:
>>
>> what?  Am I missing something here?  This sounds completely wrong.
>
>> LATER EDIT: err, ok, the comment about lilypond-book was related to
>
> producing
>>
>> multiple scores in one book.  But that only refers to that particular
>
> context;
>>
>> you can use lilypond-book without writing any explicit \book blocks.
>
> I do that
>>
>> all the time.
>
>> Please revert this change.
>
> Paragraph removed.
>
> http://codereview.appspot.com/2004041/diff/1/2#newcode422
> Documentation/notation/input.itely:422: This behaviour can be changed by
> setting the variable
> On 2010/08/16 09:31:24, Graham Percival wrote:
>>
>> Sorry, the doc policy explicitly calls for American spelling.  Please
>
> revert
>>
>> this change.
>
> Under protest.
> The doc policy sucks.
> Webster was a dyslexic (ask any non-American chemist about element Al).
>
> Description:
> T1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to
> documents (NR).
>
> Please review this at http://codereview.appspot.com/2004041/show
>
> Affected files:
>  M Documentation/notation/input.itely
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>

[Graham Percival (old account), 2011-06-08 19:15:56]

I believe that this has been pushed; could you please close the issue in
reitveld?

[Ian Hulin (gmail), 2011-06-09 05:09:13]

On 2011/06/08 19:15:56, Graham Percival wrote:
> I believe that this has been pushed; could you please close the issue in
> reitveld?

Rietveld won't let me edit this issue and I can't log in using my non-gmail
address any more to do it.
Ian