Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(454)

Issue 1995042: markup.scm: Remove unused and untested aliasing functionality from define-markup{,-list}-command (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by dak
Modified:
12 years, 12 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

markup.scm: Remove unused and untested aliasing functionality from define-markup{,-list}-command

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -55 lines) Patch
M scm/markup.scm View 3 chunks +38 lines, -55 lines 0 comments Download

Messages

Total messages: 2
Carl
LGTM. Further info: This code has been in the file since 114c05e7b0e992de7dbdd0958d23eb8d2ab1eaae (the file name ...
13 years, 7 months ago (2010-08-15 23:33:53 UTC) #1
nicolas.sceaux
13 years, 7 months ago (2010-08-16 20:50:00 UTC) #2
Le 16 août 2010 à 01:33, carl.d.sorensen@gmail.com a écrit :

> LGTM.
> 
> Further info:  This code has been in the file since
> 114c05e7b0e992de7dbdd0958d23eb8d2ab1eaae
> 
> (the file name at that time was scm/new-markup.scm).
> 
> I think that the alternate syntax has never been used in the main source
> tree

When def-markup-command (as it was called) was first introduced, there used
to be synomym commands, like "bigger" and "larger" (if I remember well).
So the aliasing thing was used at that time, and was not added just for the
fun of it, as it burdened the implementation.

Yes, larger was an alias for bigger: see
<http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commitdiff;h=114c05e7b0e...>

(it seems to be my first LilyPond patch:)

I doubt that this undocumented functionality was ever used by a user, so
a news entry seems pretty useless.  I think that it can be safely and
silently removed.

Nicolas

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b