Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2373)

Issue 199460043: Clean up inconsistencies in engraver-init.ly and performer-init.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by thomasmorley651
Modified:
9 years, 1 month ago
Reviewers:
dak, lemzwerg, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clean up inconsistencies in engraver-init.ly and performer-init.ly issue 4281 In performer-init.ly - let context-defs be copied when possible - add missing contexts for \accepts and \alias - delete settings for ChordNameVoice - add GregorianTranscriptionStaff, GregorianTranscriptionVoice, NoteNames, PetrucciStaff, PetrucciVoice - all contexts are written without quotation marks In engraver-init.ly - add FretBoards to the accepted contexts in StaffGroup

Patch Set 1 #

Patch Set 2 : correcting some oversights #

Total comments: 1

Patch Set 3 : NullVoice added to the accepted contexts for RhythmicStaff in layout #

Patch Set 4 : accepted contexts ordered alphabetical; some formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -185 lines) Patch
M ly/engraver-init.ly View 1 2 3 29 chunks +119 lines, -118 lines 0 comments Download
M ly/performer-init.ly View 1 2 3 8 chunks +101 lines, -67 lines 0 comments Download

Messages

Total messages: 9
thomasmorley651
correcting some oversights
9 years, 2 months ago (2015-02-08 22:24:07 UTC) #1
thomasmorley651
please review
9 years, 2 months ago (2015-02-08 22:30:45 UTC) #2
lemzwerg
LGTM. It would be nice if David's checker script could be added, too. https://codereview.appspot.com/199460043/diff/20001/ly/performer-init.ly File ...
9 years, 2 months ago (2015-02-09 06:09:34 UTC) #3
thomasmorley651
On 2015/02/09 06:09:34, lemzwerg wrote: > LGTM. It would be nice if David's checker script ...
9 years, 2 months ago (2015-02-09 23:46:45 UTC) #4
thomasmorley651
NullVoice added to the accepted contexts for RhythmicStaff in layout
9 years, 2 months ago (2015-02-12 22:47:37 UTC) #5
c_sorensen
On 2015/02/09 23:46:45, thomasmorley651 wrote: > > I'd happily do it, though, why alpabetically? And ...
9 years, 2 months ago (2015-02-18 18:53:03 UTC) #6
dak
On 2015/02/18 18:53:03, c_sorensen wrote: > On 2015/02/09 23:46:45, thomasmorley651 wrote: > > > > ...
9 years, 2 months ago (2015-02-18 18:57:21 UTC) #7
c_sorensen
On 2015/02/18 18:57:21, dak wrote: > On 2015/02/18 18:53:03, c_sorensen wrote: > > On 2015/02/09 ...
9 years, 2 months ago (2015-02-18 19:11:43 UTC) #8
thomasmorley651
9 years, 2 months ago (2015-02-22 13:07:16 UTC) #9
accepted contexts ordered alphabetical; some formatting
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b