Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(419)

Issue 1986042: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Carl
Modified:
13 years, 7 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) create TimeSignatureMusic to allow the display to work properly * scm/define-music-display-methods.scm define a display method for TimeSignatureMusic remove extra-display-methods for ContextSpeccedMusic and Timing that caught \time * scm/define-music-properties.scm define time-signature-arguments as a music property * scm/define-music-types.scm create make-time-signature-set for setting the time signature add TimeSignatureMusic * scm/music-functions.scm replace calls to make-beam-rule-time-signature-set with calls to make-music 'TimeSignatureMusic

Patch Set 1 #

Total comments: 8

Patch Set 2 : Move callbacks, change to individual music properties #

Patch Set 3 : Fix git merge errors from previous patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M scm/define-markup-commands.scm View 1 chunk +5 lines, -7 lines 0 comments Download
M scm/page.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Carl
I've posted a patch that fixes 1198 so \time and (set-time-signature will now be displayed ...
13 years, 7 months ago (2010-08-13 02:27:24 UTC) #1
Neil Puttock
Hi Carl, LGTM. Cheers, Neil http://codereview.appspot.com/1986042/diff/1/2 File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/1986042/diff/1/2#newcode887 scm/define-music-display-methods.scm:887: (let* ((arguments (ly:music-property expr ...
13 years, 7 months ago (2010-08-13 21:25:12 UTC) #2
Carl
Let me know about the filename for the new callbacks, and I'll add that to ...
13 years, 7 months ago (2010-08-13 22:25:43 UTC) #3
Neil Puttock
13 years, 7 months ago (2010-08-13 22:39:14 UTC) #4
On 2010/08/13 22:25:43, Carl wrote:
> Let me know about the filename for the new callbacks, and I'll add that to
this
> patch and push it.

I'd be happy with scm/define-music-callbacks.scm.

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b