Issue 1984047: Cleanup TType and related classes:...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1984047: Cleanup TType and related classes:... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by Alok Priyadarshi

Modified:
15 years ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Cleanup TType and related classes: 1. Removed unused functions 2. Removed unnecessary virtuality of functions 3. Grouped related functions together TEST=conformance tests

Patch Set 1 #

Total comments: 4

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -191 lines)			Patch
M	src/compiler/BaseTypes.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/compiler/Initialize.cpp	View	1 chunk	+10 lines, -10 lines	2 comments	Download
M	src/compiler/Intermediate.cpp	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	src/compiler/ParseHelper.cpp	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	src/compiler/SymbolTable.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/SymbolTable.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/Types.h	View	6 chunks	+76 lines, -91 lines	2 comments	Download
M	src/compiler/glslang.y	View	8 chunks	+19 lines, -14 lines	0 comments	Download
M	src/compiler/intermediate.h	View	12 chunks	+74 lines, -43 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dgkoch

no other issues spotted... http://codereview.appspot.com/1984047/diff/1/3 File src/compiler/Initialize.cpp (right): http://codereview.appspot.com/1984047/diff/1/3#newcode603 src/compiler/Initialize.cpp:603: } is there any actual ...

15 years ago (2010-08-24 21:32:39 UTC) #2

Alok Priyadarshi

http://codereview.appspot.com/1984047/diff/1/3 File src/compiler/Initialize.cpp (right): http://codereview.appspot.com/1984047/diff/1/3#newcode603 src/compiler/Initialize.cpp:603: } Visual studio did complain about inconsistent line-endings for ...

15 years ago (2010-08-24 21:35:39 UTC) #3

Ok. No other issues from me.

Daniel

Expand All Messages | Collapse All Messages