Make pure-print-callbacks public

Make pure-print-callbacks public



Make pure-print-callbacks public

[Carl, 2010-08-20 02:53:29]

LGTM

Carl

[joeneeman, 2010-08-20 16:00:27]

While this patch looks fine to me, there are a bunch of other lists with related
functionality. You may want to make some of them public too (or add public
accessor functions).

[mikesol_ufl.edu, 2010-08-20 16:24:31]

I don't know the source well enough to know the category of lists to which
you're referring.  However, I don't mind making an adder function for this
one list so that it does not have to be public.  Subsequently, people can
respond to this thread w/ suggestions for other lists/alists that should
have getter/setters and I'll write the patches accordingly.

Cheers,
Mike

On 8/20/10 12:00 PM, "joeneeman@gmail.com" <joeneeman@gmail.com> wrote:

> While this patch looks fine to me, there are a bunch of other lists with
> related functionality. You may want to make some of them public too (or
> add public accessor functions).
> 
> http://codereview.appspot.com/1983047/
> 

[mikesol_ufl.edu, 2010-08-20 16:41:02]

Adder function created.
http://codereview.appspot.com/2020041


On 8/20/10 12:29 PM, "Mike Solomon" <mikesol@ufl.edu> wrote:

> I don't know the source well enough to know the category of lists to which
> you're referring.  However, I don't mind making an adder function for this
> one list so that it does not have to be public.  Subsequently, people can
> respond to this thread w/ suggestions for other lists/alists that should
> have getter/setters and I'll write the patches accordingly.
> 
> Cheers,
> Mike
> 
> On 8/20/10 12:00 PM, "joeneeman@gmail.com" <joeneeman@gmail.com> wrote:
> 
>> While this patch looks fine to me, there are a bunch of other lists with
>> related functionality. You may want to make some of them public too (or
>> add public accessor functions).
>> 
>> http://codereview.appspot.com/1983047/
>> 
> 
> 
> 
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>