Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(713)

Issue 1973042: Add ARM assembly optimised versions of memset{16,32} (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Sledge
Modified:
13 years, 7 months ago
Base URL:
http://skia.googlecode.com/svn/trunk/src/opts/
Visibility:
Public.

Description

Add versions of memset16() and memset32() in ARM assembly. In benchmarks here on Cortex A9 processors, this code runs 25-30% faster than the C equivalent.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
A memset.arm.S View 1 chunk +110 lines, -0 lines 0 comments Download
A opts_check_arm.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Sledge
As described in http://codereview.appspot.com/1157045/show , here's ARM assembly code that works faster on ARM processors ...
13 years, 7 months ago (2010-08-11 15:10:37 UTC) #1
agl
I'll wait a day to see if anyone objects before landing. Have you signed the ...
13 years, 7 months ago (2010-08-11 15:23:08 UTC) #2
Sledge
On 2010/08/11 15:23:08, agl wrote: > I'll wait a day to see if anyone objects ...
13 years, 7 months ago (2010-08-11 16:40:04 UTC) #3
Sledge
On 2010/08/11 16:40:04, Sledge wrote: > I believe that ARM have an agreement in place. ...
13 years, 7 months ago (2010-08-12 09:54:02 UTC) #4
piman
LGTM
13 years, 7 months ago (2010-08-12 22:39:16 UTC) #5
agl
13 years, 7 months ago (2010-08-13 17:05:56 UTC) #6
On Thu, Aug 12, 2010 at 6:39 PM,  <piman@chromium.org> wrote:
> LGTM

Landed as r594.


AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b