Issue 1965045: Allow derivative functions if derivative extension is enabled. I still need t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1965045: Allow derivative functions if derivative extension is enabled. I still need t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Alok Priyadarshi

Modified:
13 years, 8 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allow derivative functions if derivative extension is enabled. I still need to add validation for "#extension GL_OES_standard_derivatives : enable". BUG=25

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -23 lines)			Patch
M	src/compiler/Initialize.cpp	View	4 chunks	+21 lines, -17 lines	0 comments	Download
M	src/compiler/OutputGLSL.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/compiler/intermediate.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

Looks good to me though I'm not an expert on the compiler internals.

13 years, 8 months ago (2010-08-25 23:16:50 UTC) #2

looks good here too.

Expand All Messages | Collapse All Messages