Remove PushRel in exception handling

[ebo, 2010-08-17 06:30:03]

This removes PushRel from exception handling.
Exceptions are stored in extra allocas and wrote on the correct stack position
before entering the handler block.

[Reid Kleckner, 2010-08-17 17:54:15]

LGTM

http://codereview.appspot.com/1958046/diff/1/4
File JIT/llvm_fbuilder.cc (right):

http://codereview.appspot.com/1958046/diff/1/4#newcode601
JIT/llvm_fbuilder.cc:601: // Just store the exception in allocas.
I'd elaborate here along the lines of:
We don't know which stack slots the exc triplet is going into until later, so we
save it in an alloca and let the opcode implementations copy it into the correct
stack slots.

[strombrg_gmail.com, 2010-08-30 00:28:40]

A half-rhetorical question:

Has alloca grown more portable over the years?

alloca used to be somewhat frowned upon.  Granted it's convenient when you
have it, but at least at one time not all systems had it:

http://compilers.iecc.com/comparch/article/91-12-079

On Tue, Aug 17, 2010 at 10:54 AM, <reid.kleckner@gmail.com> wrote:

> LGTM
>
>
> http://codereview.appspot.com/1958046/diff/1/4
> File JIT/llvm_fbuilder.cc (right):
>
> http://codereview.appspot.com/1958046/diff/1/4#newcode601
> JIT/llvm_fbuilder.cc:601: // Just store the exception in allocas.
> I'd elaborate here along the lines of:
> We don't know which stack slots the exc triplet is going into until
> later, so we save it in an alloca and let the opcode implementations
> copy it into the correct stack slots.
>
>
> http://codereview.appspot.com/1958046/
>



-- 
Dan Stromberg

[Reid Kleckner, 2010-08-30 14:51:47]

In LLVM, alloca is the name of the instruction that allocates stack
space.  I think you can give it an argument that isn't a constant, but
generally speaking you give it a constant argument and it gives you
some local stack space.  It's used for all of your local variables.

Reid

On Sun, Aug 29, 2010 at 5:28 PM, Dan Stromberg <strombrg@gmail.com> wrote:
>
> A half-rhetorical question:
> Has alloca grown more portable over the years?
> alloca used to be somewhat frowned upon.  Granted it's convenient when you
> have it, but at least at one time not all systems had it:
>
> http://compilers.iecc.com/comparch/article/91-12-079
> On Tue, Aug 17, 2010 at 10:54 AM, <reid.kleckner@gmail.com> wrote:
>>
>> LGTM
>>
>>
>> http://codereview.appspot.com/1958046/diff/1/4
>> File JIT/llvm_fbuilder.cc (right):
>>
>> http://codereview.appspot.com/1958046/diff/1/4#newcode601
>> JIT/llvm_fbuilder.cc:601: // Just store the exception in allocas.
>> I'd elaborate here along the lines of:
>> We don't know which stack slots the exc triplet is going into until
>> later, so we save it in an alloca and let the opcode implementations
>> copy it into the correct stack slots.
>>
>> http://codereview.appspot.com/1958046/
>
>
>
> --
> Dan Stromberg
>