Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(884)

Issue 1956042: Fixed Display::initialize so it does not crash for devices that do not suppor...

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by apatrick1
Modified:
13 years, 8 months ago
Reviewers:
gav, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed Display::initialize so it does not crash for devices that do not support PS 2.0. The crash occurs when createDevice attempts to dereference mD3d9, which is NULL.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -59 lines) Patch
M src/libEGL/Display.cpp View 1 chunk +57 lines, -59 lines 2 comments Download

Messages

Total messages: 3
apatrick1
Hi, This is a fairly simple change but it's pretty high priority for us because ...
13 years, 8 months ago (2010-08-11 22:05:17 UTC) #1
dgkoch
Looks alright. I believe the bulk of the changes is just indentation, correct?
13 years, 8 months ago (2010-08-11 23:48:13 UTC) #2
apatrick1
13 years, 8 months ago (2010-08-11 23:59:35 UTC) #3
Hi Dan, Thanks for the fast feedback. You are correct about the indentation.

Al

http://codereview.appspot.com/1956042/diff/1/2
File src/libEGL/Display.cpp (right):

http://codereview.appspot.com/1956042/diff/1/2#newcode74
src/libEGL/Display.cpp:74: return error(EGL_NOT_INITIALIZED, false);
The only change functionality is this block here that earlies out if the PS
model is less than 2.0.

http://codereview.appspot.com/1956042/diff/1/2#newcode76
src/libEGL/Display.cpp:76: 
Changes from here down are just indentation changes to account from the removal
of the else branch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b