Fixed crash on context lost....

Fixed crash on context lost.

This fixes the crash on lost context for vista and windows 7 if suitable drivers are available. It now uses D3D9Ex when available and this only reports lost contexts for hardware failures and suchlike.

Testing procedure was:
- run simple_vertex_shader without this change.
- ctrl+alt+del to lock machine.
- return to desktop.
- observe that simple_vertex_shader crashes.
- repeat with this change and check that simple_vertex_shader is still animating.
- simulate the code path that an XP machine would take using the debugger and check that old behavior is preserved.

I decided to load D3D9.DLL at runtime for a couple of reasons. First, I didn't want to assume that older implementations of D3D9 would have the Direct3DCreate9Ex entry point. Second, it might be advantageous for some applications to not have a load time dependency on D3D9. I didn't address this for D3DX9 because it's a little harder - there's no clear way to determine which D3DX9_x.DLL library to open. At least D3DX9_x.DLL does not seem to import D3D9.DLL and D3DX is separately redistributable so there is still some advantage to be had.

[apatrick1, 2010-08-16 21:18:09]

Hi Daniel,

This fixes our lost context / crash issue at least for Vista and Windows 7
machines. Can you take a look?

Thanks,

Al

[apatrick1, 2010-08-16 23:07:10]

+gav

Hi Gav,

I found a way to work around the lost context issues on Vista and Windows 7
(with sufficient driver support). This doesn't need to be the long term
solution. We would like to have a solution of some sort though, even if it's
temporary, this week. Is there anyone who could take a look at this changelist?

It also occurred to me that another thing it's worth considering with regard to
D3D9Ex is that, at some point in the future, we're going to want to share D3D
surfaces between devices and processes.

Thanks

Al

[gav, 2010-08-17 01:46:24]

Hi al,

I'll forward this along to one of our ANGLE developers; it looked good to me at
first glance.

I wouldn't consider the D3D9Ex switch to be a short term solution only; I think
that it will be the best long term solution for Vista and Win7. For Pre-Vista
systems, the best we'll be able to do is report the lost context (and of course
properly support creating a new context once the context is lost, which we
aren't doing now). Apps will still need to be able to handle the GL lost context
case properly regardless since it could happen on hardware ES devices as well.

Take care,
 -Gav

On 2010-08-16, at 7:07 PM, apatrick@chromium.org wrote:

> +gav
> 
> Hi Gav,
> 
> I found a way to work around the lost context issues on Vista and
> Windows 7 (with sufficient driver support). This doesn't need to be the
> long term solution. We would like to have a solution of some sort
> though, even if it's temporary, this week. Is there anyone who could
> take a look at this changelist?
> 
> It also occurred to me that another thing it's worth considering with
> regard to D3D9Ex is that, at some point in the future, we're going to
> want to share D3D surfaces between devices and processes.
> 
> Thanks
> 
> Al
> 
> http://codereview.appspot.com/1951044/

--
Gavriel State
Founder&  CTO
TransGaming Inc.
gav@transgaming.com
http://www.transgaming.com

Broadening The Playing Field

[gav, 2010-08-17 22:17:38]

Hi Al,

Nicolas looked this over as well, and it seems good to him too.

--
Gavriel State
Founder&  CTO
TransGaming Inc.
gav@transgaming.com
http://www.transgaming.com

[apatrick, 2010-08-17 22:21:21]

On Tue, Aug 17, 2010 at 3:17 PM, Gavriel State <gav@transgaming.com> wrote:
> Hi Al,
>
> Nicolas looked this over as well, and it seems good to him too.

Thanks Gav,

I landed it as r384. Let me know if you have any problems.

Al