Moving HtmlAccelServlet from "default" container to "accel" container

Currently the container for accelerate use case is hardcoded as "default". This change adds a new "accel" container and points HtmlAccelServlet and AccelUriManager to use this container.

This change should go in only after the bug for percolating container information throughout has been resolved. Refer to https://issues.apache.org/jira/browse/SHINDIG-1411 for more info on the bug, and here for relevant codereviews:
http://codereview.appspot.com/2004042/
http://codereview.appspot.com/1888046/

[anupama.dutta, 2010-08-21 10:47:25]

http://codereview.appspot.com/1949048/diff/2001/3003
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java
(right):

http://codereview.appspot.com/1949048/diff/2001/3003#newcode37
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java:37:
* TODO: Refactor this method to take HttpRequest rather than just Uri so
Couldn't we make this change right away?

http://codereview.appspot.com/1949048/diff/2001/3001
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManagerTest.java
(left):

http://codereview.appspot.com/1949048/diff/2001/3001#oldcode22
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManagerTest.java:22:

Retain this newline?

[gagan.goku, 2010-08-21 11:15:16]

http://codereview.appspot.com/1949048/diff/2001/3003
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java
(right):

http://codereview.appspot.com/1949048/diff/2001/3003#newcode37
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/AccelUriManager.java:37:
* TODO: Refactor this method to take HttpRequest rather than just Uri so
On 2010/08/21 10:47:25, anupama.dutta wrote:
> Couldn't we make this change right away?

Good point. What was i thinking ??
Done.

http://codereview.appspot.com/1949048/diff/2001/3001
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManagerTest.java
(left):

http://codereview.appspot.com/1949048/diff/2001/3001#oldcode22
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultAccelUriManagerTest.java:22:

On 2010/08/21 10:47:25, anupama.dutta wrote:
> Retain this newline?

removed by intellij when i did lint formatting.

[anupama.dutta, 2010-08-24 11:23:38]

LGTM.

[gagan.goku, 2010-08-24 12:15:44]

On 2010/08/24 11:23:38, anupama.dutta wrote:
> LGTM.

Thanks for the review Anupama. Sent the codereview to dev@

[zhoresh, 2010-08-24 17:02:22]

lgtm

http://codereview.appspot.com/1949048/diff/7001/2007
File config/container.js (right):

http://codereview.appspot.com/1949048/diff/7001/2007#newcode125
config/container.js:125: "gadgets.uri.proxy.path" : "/gadgets/proxy",
I would create independent config for accel and point proxy back to accel
servlet (only change).

[gagan.goku, 2010-08-24 17:09:00]

http://codereview.appspot.com/1949048/diff/7001/2007
File config/container.js (right):

http://codereview.appspot.com/1949048/diff/7001/2007#newcode125
config/container.js:125: "gadgets.uri.proxy.path" : "/gadgets/proxy",
On 2010/08/24 17:02:22, zhoresh wrote:
> I would create independent config for accel and point proxy back to accel
> servlet (only change).

Thanks for the review Ziv. Could you give me some pointers on how to create a
new container config in shindig.
Which directory do I need to add accel.js to ?

I tried doing this once, but could not figure out how to get accel.js to be
packaged along with container.js
I modified shindig.containers.default to say something like
"res://containers/default/container.js,res://containers/default/accel.js", but
could not get the .war file to pick up accel.js as well.

A pointer on adding accel.js as a container would be greatly appreciated.

[zhoresh, 2010-08-24 17:45:07]

I see your dilemma. Sorry I never wrote container config in Shindig myself
either so I will be trying like you do.


On Tue, Aug 24, 2010 at 10:09 AM, <gagan.goku@gmail.com> wrote:

>
> http://codereview.appspot.com/1949048/diff/7001/2007
> File config/container.js (right):
>
> http://codereview.appspot.com/1949048/diff/7001/2007#newcode125
> config/container.js:125: "gadgets.uri.proxy.path" : "/gadgets/proxy",
> On 2010/08/24 17:02:22, zhoresh wrote:
>
>> I would create independent config for accel and point proxy back to
>>
> accel
>
>> servlet (only change).
>>
>
> Thanks for the review Ziv. Could you give me some pointers on how to
> create a new container config in shindig.
> Which directory do I need to add accel.js to ?
>
> I tried doing this once, but could not figure out how to get accel.js to
> be packaged along with container.js
> I modified shindig.containers.default to say something like
> "res://containers/default/container.js,res://containers/default/accel.js",
> but could not get the .war file to pick up accel.js as well.
>
> A pointer on adding accel.js as a container would be greatly
> appreciated.
>
>
> http://codereview.appspot.com/1949048/
>

[gagan.goku, 2010-08-25 07:37:15]

On 2010/08/24 17:45:07, zhoresh wrote:
> I see your dilemma. Sorry I never wrote container config in Shindig myself
> either so I will be trying like you do.
> 
> 
> On Tue, Aug 24, 2010 at 10:09 AM, <mailto:gagan.goku@gmail.com> wrote:
> 
> >
> > http://codereview.appspot.com/1949048/diff/7001/2007
> > File config/container.js (right):
> >
> > http://codereview.appspot.com/1949048/diff/7001/2007#newcode125
> > config/container.js:125: "gadgets.uri.proxy.path" : "/gadgets/proxy",
> > On 2010/08/24 17:02:22, zhoresh wrote:
> >
> >> I would create independent config for accel and point proxy back to
> >>
> > accel
> >
> >> servlet (only change).
> >>
> >
> > Thanks for the review Ziv. Could you give me some pointers on how to
> > create a new container config in shindig.
> > Which directory do I need to add accel.js to ?
> >
> > I tried doing this once, but could not figure out how to get accel.js to
> > be packaged along with container.js
> > I modified shindig.containers.default to say something like
> > "res://containers/default/container.js,res://containers/default/accel.js",
> > but could not get the .war file to pick up accel.js as well.
> >
> > A pointer on adding accel.js as a container would be greatly
> > appreciated.
> >
> >
> > http://codereview.appspot.com/1949048/
> >
> 

Hi Ziv

For now, i have added a TODO in container.js to move out the accel container
config into a separate accel.js file.
Please take another look.

Thanks
Gagan

[zhoresh, 2010-08-25 17:27:39]

lgtm, committed @ r989233

[gagan.goku, 2010-08-25 17:35:57]

Thanks Ziv :)

On Wed, Aug 25, 2010 at 10:57 PM, <zhoresh@gmail.com> wrote:

> lgtm, committed @ r989233
>
>
> http://codereview.appspot.com/1949048/
>