Issue 194100043: Remove Unfolded_repeat_iterator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194100043: Remove Unfolded_repeat_iterator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by Dan Eble

Modified:
9 years, 3 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove Unfolded_repeat_iterator and rely on Sequential_iterator with a customized elements-callback which is factored out of unfold-repeats-fully.

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -76 lines)			Patch
D	lily/unfolded-repeat-iterator.cc	View	1 chunk	+0 lines, -63 lines	0 comments	Download
M	scm/define-music-callbacks.scm	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	scm/define-music-types.scm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	scm/music-functions.scm	View	1 chunk	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

9 years, 3 months ago (2015-01-11 07:26:54 UTC) #2

On 2015/01/09 05:03:04, Dan Eble wrote:
> Does this make sense?  TIA.

It seems to work fine.  I don't know your goal.  Simply removing the strange
duplication between the unfolded-repeat iterator and the function
unfold-repeats-fully would be enough of a goal.  Put the reason for the change
in the Description or the tracker item when you have a chance.

There was a related patch http://code.google.com/p/lilypond/issues/detail?id=769
working toward nicer behavior of repeats in midi.

Expand All Messages | Collapse All Messages