code review 194098: More steps towards tracking of identifier scopes.

More steps towards tracking of identifier scopes.
- provide scope to parse functions; if non-nil, parser uses the scope
  to declare and lookup identifiers
- resolve forward references where possible

[gri, 2010-01-27 02:00:01]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-01-27 02:19:47]

LGTM

http://codereview.appspot.com/194098/diff/28/39
File src/pkg/go/parser/parser.go (right):

http://codereview.appspot.com/194098/diff/28/39#newcode1824
src/pkg/go/parser/parser.go:1824: p.declIdent(p.fileScope, ident)
In addition to declaring the ident in the file scope,
the parser needs to check that it is not already
declared in the package scope (that's an error)
and also leave some indication in the package scope
that it is invalid to introduce such a name in the future.

[gri, 2010-01-27 02:29:04]

On Tue, Jan 26, 2010 at 6:19 PM, <rsc@google.com> wrote:

> LGTM
>
>
>
> http://codereview.appspot.com/194098/diff/28/39
> File src/pkg/go/parser/parser.go (right):
>
> http://codereview.appspot.com/194098/diff/28/39#newcode1824
> src/pkg/go/parser/parser.go:1824: p.declIdent(p.fileScope, ident)
> In addition to declaring the ident in the file scope,
> the parser needs to check that it is not already
> declared in the package scope (that's an error)
> and also leave some indication in the package scope
> that it is invalid to introduce such a name in the future.


Yes - I am aware of this. Next step.

>
>
> http://codereview.appspot.com/194098/show
>

[gri, 2010-01-27 17:44:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=e35ee9761bc1 ***

More steps towards tracking of identifier scopes.
- provide scope to parse functions; if non-nil, parser uses the scope
  to declare and lookup identifiers
- resolve forward references where possible

R=rsc
CC=golang-dev
http://codereview.appspot.com/194098