Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)

Issue 194090043: Reduce size of PDF files when inc. in *TeX docs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by pkx166h
Modified:
11 years ago
Reviewers:
Keith, wl, knut_petersen, dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Reduce size of PDF files when inc. in *TeX docs Issue 4251 This changes the way lilypond uses fonts to draw glyphs. It avoids to used glyphshow for all emmentaler glyphs and adds encoding vectors to the emmentaler fonts before they are used. It also changes the ghostscript parameters used to generate pdfs from postscript code. These changes help to reduce pdf file sizes if you include lilypond snippets in *TeX documents. The pdfs generated by a patched lilypond and *tex themselves are _much_ bigger, but if you run ghostscript and pdfsizeopt.py on those files they implode. added a command line option --bigpdf / -b, and documented that option in the german and english versions of usage.pdf .

Patch Set 1 #

Total comments: 10

Patch Set 2 : Format corrections from Werner, rewrite of English entry for Usage. #

Total comments: 16

Patch Set 3 : Corrections as per Werner, plus new edit to the English doc #

Total comments: 16

Patch Set 4 : Corrections from Werner, some scm formatting and TexInfo syntax fixes #

Patch Set 5 : CHange of German Translation - if and when this compiles this will get pushed. The rest of the patc… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2008 lines, -29 lines) Patch
M Documentation/de/usage/running.itely View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
M Documentation/usage/running.itely View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M lily/general-scheme.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M lily/global-vars.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/include/main.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/main.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
A ps/encodingdefs.ps View 1 2 1 chunk +1848 lines, -0 lines 0 comments Download
M scm/backend-library.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/framework-ps.scm View 4 chunks +47 lines, -6 lines 0 comments Download
M scm/output-ps.scm View 1 2 3 2 chunks +35 lines, -23 lines 0 comments Download

Messages

Total messages: 47
pkx166h
Added Knut as I 'own' this patch while it is being reviewed. James
11 years, 1 month ago (2015-01-08 18:10:32 UTC) #1
pkx166h
The English Documentation is not very well written - which I completely understand of course ...
11 years, 1 month ago (2015-01-09 08:23:25 UTC) #2
lemzwerg
LGTM, thanks! I only have some minor comments regarding improved legibility of the source code. ...
11 years, 1 month ago (2015-01-10 10:02:07 UTC) #3
pkx166h
Format corrections from Werner, rewrite of English entry for Usage.
11 years, 1 month ago (2015-01-11 16:22:43 UTC) #4
pkx166h
Thanks https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/1/Documentation/de/usage/running.itely#newcode160 Documentation/de/usage/running.itely:160: pdftex-, xetex-, oder luatex-Dokumente eingebettet werden, On 2015/01/10 ...
11 years, 1 month ago (2015-01-11 16:23:15 UTC) #5
lemzwerg
Thanks for your help and assistance! > > For better orientation, please reformat this to ...
11 years, 1 month ago (2015-01-11 20:13:29 UTC) #6
lemzwerg
https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely#newcode160 Documentation/de/usage/running.itely:160: pdftex-, xetex-, oder luatex-Dokumente eingebettet werden; I suggest to ...
11 years, 1 month ago (2015-01-11 20:13:46 UTC) #7
pkx166h
On 2015/01/11 20:13:46, lemzwerg wrote: > https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely > File Documentation/de/usage/running.itely (right): > > https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely#newcode160 > ...
11 years, 1 month ago (2015-01-11 22:54:44 UTC) #8
lemzwerg
https://codereview.appspot.com/194090043/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/20001/Documentation/usage/running.itely#newcode187 Documentation/usage/running.itely:187: font data which can make significant reductions in file ...
11 years, 1 month ago (2015-01-12 05:56:14 UTC) #9
Knut_Petersen_t-online.de
On 12.01.2015 06:56, lemzwerg@googlemail.com wrote: > > https://codereview.appspot.com/194090043/diff/20001/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/194090043/diff/20001/Documentation/usage/running.itely#newcode187 ...
11 years, 1 month ago (2015-01-12 07:55:58 UTC) #10
lemzwerg
I don't object to the name! I only state that the option's name doesn't have ...
11 years, 1 month ago (2015-01-12 08:52:02 UTC) #11
pkx166h
On 2015/01/12 08:52:02, lemzwerg wrote: > I don't object to the name! I only state ...
11 years, 1 month ago (2015-01-12 11:13:33 UTC) #12
lemzwerg
Hmm. I can't find in your description that `--bigpdfs' creates *big* output files that get ...
11 years, 1 month ago (2015-01-14 07:15:13 UTC) #13
Knut_Petersen_t-online.de
On 14.01.2015 08:15, lemzwerg@googlemail.com wrote: > Hmm. I can't find in your description that `--bigpdfs' ...
11 years, 1 month ago (2015-01-14 08:25:46 UTC) #14
lemzwerg
Knut, *your* patch set has this, but James's version (in patch set 2) misses it.
11 years, 1 month ago (2015-01-14 08:42:27 UTC) #15
pkx166h
On 2015/01/14 08:42:27, lemzwerg wrote: > Knut, *your* patch set has this, but James's version ...
11 years, 1 month ago (2015-01-14 10:35:15 UTC) #16
lemzwerg
David's concerns are very specific to the Lilypond documentation, not covering the general case. Many ...
11 years, 1 month ago (2015-01-15 07:08:33 UTC) #17
dak
On 2015/01/15 07:08:33, lemzwerg wrote: > David's concerns are very specific to the Lilypond documentation, ...
11 years, 1 month ago (2015-01-15 09:45:58 UTC) #18
lemzwerg
Well, we get a large size reduction even if we don't use pdfsizeopt! Using this ...
11 years, 1 month ago (2015-01-15 11:49:52 UTC) #19
Knut_Petersen_t-online.de
On 15.01.2015 10:45, dak@gnu.org wrote: > > Reliable? If I remember correctly, the tool used ...
11 years, 1 month ago (2015-01-15 12:01:55 UTC) #20
Knut_Petersen_t-online.de
On 15.01.2015 12:49, lemzwerg@googlemail.com wrote: > > The hyperlink issue is not related to the ...
11 years, 1 month ago (2015-01-15 12:09:08 UTC) #21
dak
On 2015/01/15 12:01:55, Knut_Petersen_t-online.de wrote: > On 15.01.2015 10:45, mailto:dak@gnu.org wrote: > > > > ...
11 years, 1 month ago (2015-01-15 12:12:12 UTC) #22
dak
On 2015/01/15 12:01:55, Knut_Petersen_t-online.de wrote: > On 15.01.2015 10:45, mailto:dak@gnu.org wrote: > > > > ...
11 years, 1 month ago (2015-01-15 12:15:41 UTC) #23
Knut_Petersen_t-online.de
On 15.01.2015 13:15, dak@gnu.org wrote: > On 2015/01/15 12:01:55, Knut_Petersen_t-online.de wrote: > >> Ghostscript does ...
11 years, 1 month ago (2015-01-15 13:18:46 UTC) #24
pkx
On 15/01/15 13:18, Knut Petersen wrote: > On 15.01.2015 13:15, dak@gnu.org wrote: >> On 2015/01/15 ...
11 years, 1 month ago (2015-01-15 13:20:10 UTC) #25
Knut_Petersen_t-online.de
On 15.01.2015 13:12, dak@gnu.org wrote: > > If external hyperlinks from our documentation PDF to ...
11 years, 1 month ago (2015-01-15 13:43:14 UTC) #26
dak
On 2015/01/15 13:18:46, Knut_Petersen_t-online.de wrote: > On 15.01.2015 13:15, mailto:dak@gnu.org wrote: > > On 2015/01/15 ...
11 years, 1 month ago (2015-01-15 13:47:52 UTC) #27
Knut_Petersen_t-online.de
On 15.01.2015 14:47, dak@gnu.org wrote: > On 2015/01/15 13:18:46, Knut_Petersen_t-online.de wrote: >> On 15.01.2015 13:15, ...
11 years, 1 month ago (2015-01-15 15:06:06 UTC) #28
dak
On 2015/01/15 15:06:06, Knut_Petersen_t-online.de wrote: > On 15.01.2015 14:47, mailto:dak@gnu.org wrote: > > On 2015/01/15 ...
11 years, 1 month ago (2015-01-15 16:01:27 UTC) #29
Knut_Petersen_t-online.de
On 15.01.2015 17:01, dak@gnu.org wrote: > > PDFTeX apparently does merge subsetted fonts, Which version? ...
11 years, 1 month ago (2015-01-15 18:20:43 UTC) #30
dak
Knut Petersen <Knut_Petersen@t-online.de> writes: > On 15.01.2015 17:01, dak@gnu.org wrote: >> >> PDFTeX apparently does ...
11 years, 1 month ago (2015-01-15 18:34:34 UTC) #31
Keith
I have not yet used LilyPond with TeX, so I have no opinion. I looked ...
11 years, 1 month ago (2015-01-18 06:33:02 UTC) #32
pkx166h
On 2015/01/11 20:13:29, lemzwerg wrote: > Thanks for your help and assistance! > > > ...
11 years, 1 month ago (2015-01-20 19:34:07 UTC) #33
pkx166h
Corrections as per Werner, plus new edit to the English doc
11 years, 1 month ago (2015-01-20 21:18:27 UTC) #34
pkx166h
Thanks for your patience. https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/20001/Documentation/de/usage/running.itely#newcode166 Documentation/de/usage/running.itely:166: notation.pdf (Lilypond 2.18.2) ist ca. ...
11 years, 1 month ago (2015-01-20 21:19:27 UTC) #35
lemzwerg
Thank *you* for your hard work. Here's the next round of comments. https://codereview.appspot.com/194090043/diff/40001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely ...
11 years, 1 month ago (2015-01-20 22:38:05 UTC) #36
wl_gnu.org
>> In case of doubt, the formatting produced by Emacs is the one we >> ...
11 years, 1 month ago (2015-01-20 22:41:38 UTC) #37
Keith
On Tue, 20 Jan 2015 13:19:26 -0800, <pkx166h@gmail.com> wrote: > https://codereview.appspot.com/194090043/diff/20001/ps/encodingdefs.ps#newcode8 > ps/encodingdefs.ps:8: /LilyNoteHeadEncoding [ ...
11 years, 1 month ago (2015-01-21 03:33:43 UTC) #38
pkx166h
Corrections from Werner, some scm formatting and TexInfo syntax fixes
11 years, 1 month ago (2015-01-24 14:09:18 UTC) #39
pkx166h
Thanks to all https://codereview.appspot.com/194090043/diff/40001/Documentation/de/usage/running.itely File Documentation/de/usage/running.itely (right): https://codereview.appspot.com/194090043/diff/40001/Documentation/de/usage/running.itely#newcode160 Documentation/de/usage/running.itely:160: pdftex-, xetex-, oder luatex-Dokumente eingebettet werden; ...
11 years, 1 month ago (2015-01-24 14:09:45 UTC) #40
pkx166h
On 2015/01/20 22:41:38, wl_gnu.org wrote: > >> In case of doubt, the formatting produced by ...
11 years, 1 month ago (2015-01-24 14:10:46 UTC) #41
dak
On 2015/01/24 14:10:46, J_lowe wrote: > On 2015/01/20 22:41:38, http://wl_gnu.org wrote: > > >> In ...
11 years, 1 month ago (2015-01-24 14:33:36 UTC) #42
lemzwerg
Ah, nice! I wasn't aware of this script. Thanks for mentioning it.
11 years, 1 month ago (2015-01-24 18:34:07 UTC) #43
pkx166h
Patch on countdown for Jan 29th
11 years, 1 month ago (2015-01-26 12:51:54 UTC) #44
pkx166h
Can someone give me the translation in German for: "PDF files generated will be much ...
11 years ago (2015-01-29 18:44:26 UTC) #45
pkx166h
CHange of German Translation - if and when this compiles this will get pushed. The ...
11 years ago (2015-01-31 12:02:30 UTC) #46
pkx166h
11 years ago (2015-01-31 13:01:02 UTC) #47
Knut,

author	Knut Petersen <knut_petersen@online.de>	
	Thu, 8 Jan 2015 18:00:44 +0000 (18:00 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 31 Jan 2015 12:57:08 +0000 (12:57 +0000)
commit	cd5b559ab016dad5100eab3105218df94ab9f402

Thanks for your work.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b