Refactor import_data

Rebirth of the patch from h.goebel

- translate error message
- handle numeric, date, datetime, reference fields
- Improve relation search to fail if too much is found
- Add unittest
- Add escapechar '\' for ',' in many2many list

[bch, 2010-01-25 13:49:36]

On 2010/01/24 21:10:04, ced wrote:
> 

OK

[h.goebel, 2010-01-26 07:39:13]

General remarks

* Testsuite is to monolithic. Putting all tests in a single file will result in
hard to maintain tests and hinders modular tests.

* Negatives tests are missing at all.

* Tests for eg. Categories (rec_name) are missing. Same for other "real world"
data.

* Mind the credits. 95% of the refactoring code have been written by me.

http://codereview.appspot.com/194047/diff/1/9
File trytond/tests/test_tryton.py (right):

http://codereview.appspot.com/194047/diff/1/9#newcode2938
trytond/tests/test_tryton.py:2938: def test0010boolean(self):
A lot of redundant code here. You should use loops.

http://codereview.appspot.com/194047/diff/1/9#newcode3333
trytond/tests/test_tryton.py:3333: suite = suite()
All these lines should go into function suite().
See http://docs.python.org/library/unittest.html#organizing-test-code, last
quarter for how to use "suite()"

[ced, 2010-01-26 10:12:44]

On 2010/01/26 07:39:13, h.goebel wrote:
> General remarks
> 
> * Testsuite is to monolithic. Putting all tests in a single file will result
in
> hard to maintain tests and hinders modular tests.

I tried but it doesn't work out of the box. So it will be for an other patch.

> 
> * Negatives tests are missing at all.

There are negative tests.

> 
> * Tests for eg. Categories (rec_name) are missing. Same for other "real world"
> data.

This is not part of this unittest.

> 
> * Mind the credits. 95% of the refactoring code have been written by me.

It is in the description.

[ced, 2010-01-26 10:15:16]

http://codereview.appspot.com/194047/diff/1/9
File trytond/tests/test_tryton.py (right):

http://codereview.appspot.com/194047/diff/1/9#newcode2938
trytond/tests/test_tryton.py:2938: def test0010boolean(self):
On 2010/01/26 07:39:13, h.goebel wrote:
> A lot of redundant code here. You should use loops.

It is tests and I find it is more readable.

http://codereview.appspot.com/194047/diff/1/9#newcode3333
trytond/tests/test_tryton.py:3333: suite = suite()
On 2010/01/26 07:39:13, h.goebel wrote:
> All these lines should go into function suite().
> See http://docs.python.org/library/unittest.html#organizing-test-code, last
> quarter for how to use "suite()"

Yes, this is why it is done like that. Other modules will only need of the
DBTestCase.

http://codereview.appspot.com/194047/diff/1/9#newcode3333
trytond/tests/test_tryton.py:3333: suite = suite()
On 2010/01/26 07:39:13, h.goebel wrote:
> All these lines should go into function suite().
> See http://docs.python.org/library/unittest.html#organizing-test-code, last
> quarter for how to use "suite()"

Yes, this is why it is done like that. Other modules will only need of the
DBTestCase.