TIntermBinary::promote() was incorrectly marking the type of result as const ...

TIntermBinary::promote() was incorrectly marking the type of result as const in some cases. The result can only be const if both operands are const. Also cleaned up the function to remove redundant/repeated checks.
BUG=24
TEST=OpenGL ES 2.0 Conformance tests

[kbr1, 2010-08-23 20:17:28]

LGTM. Couple of comments / questions.

http://codereview.appspot.com/1938047/diff/1/2
File src/compiler/Intermediate.cpp (left):

http://codereview.appspot.com/1938047/diff/1/2#oldcode118
src/compiler/Intermediate.cpp:118: rightTempConstant =
right->getAsConstantUnion();
Was this just redundant code?

http://codereview.appspot.com/1938047/diff/1/2#oldcode978
src/compiler/Intermediate.cpp:978: break;
Would it be worth in leaving these tests in the form of an assertion?

http://codereview.appspot.com/1938047/diff/1/2
File src/compiler/Intermediate.cpp (right):

http://codereview.appspot.com/1938047/diff/1/2#newcode764
src/compiler/Intermediate.cpp:764: if (left->getBasicType() !=
right->getBasicType())
I assume this does not affect constructors, which do allow type promotion?

http://codereview.appspot.com/1938047/diff/1/2#newcode854
src/compiler/Intermediate.cpp:854: // The other operand could be a sclar,
vector, or matrix.
Typo: scalar

[Alok Priyadarshi, 2010-08-23 20:41:30]

http://codereview.appspot.com/1938047/diff/1/2
File src/compiler/Intermediate.cpp (left):

http://codereview.appspot.com/1938047/diff/1/2#oldcode118
src/compiler/Intermediate.cpp:118: rightTempConstant =
right->getAsConstantUnion();
Yes as you can see it does the casting just above.

http://codereview.appspot.com/1938047/diff/1/2#oldcode978
src/compiler/Intermediate.cpp:978: break;
I removed it because it is incomplete. The assignment can also be in the form of
EOpVectorTimesScalarAssign, EOpMatrixTimesScalarAssign, etc. I will add a more
complete assert in the next CL because it will need to touch a few more files.

http://codereview.appspot.com/1938047/diff/1/2
File src/compiler/Intermediate.cpp (right):

http://codereview.appspot.com/1938047/diff/1/2#newcode764
src/compiler/Intermediate.cpp:764: if (left->getBasicType() !=
right->getBasicType())
constructors are unary operators. This CL only affects binary operators.

http://codereview.appspot.com/1938047/diff/1/2#newcode854
src/compiler/Intermediate.cpp:854: // The other operand could be a sclar,
vector, or matrix.
On 2010/08/23 20:17:29, kbr1 wrote:
> Typo: scalar

Done.

[dgkoch, 2010-08-23 20:55:44]

no issues here