looks good, self-contained, very minor detail. It would be cool if you could provide some ...
14 years, 1 month ago
(2010-01-26 14:55:05 UTC)
#1
looks good, self-contained, very minor detail. It would be cool if you could
provide some tests with this though.
http://codereview.appspot.com/193105/diff/1/2
File src/mobility/steady-state-random-waypoint-mobility-model.cc (right):
http://codereview.appspot.com/193105/diff/1/2#newcode121
src/mobility/steady-state-random-waypoint-mobility-model.cc:121: if(v0 == v1)
missing braces around single-line statements
On 2010/01/26 14:55:05, Mathieu Lacage wrote: > looks good, self-contained, very minor detail. It would ...
14 years, 1 month ago
(2010-01-28 15:09:21 UTC)
#2
On 2010/01/26 14:55:05, Mathieu Lacage wrote:
> looks good, self-contained, very minor detail. It would be cool if you could
> provide some tests with this though.
>
> http://codereview.appspot.com/193105/diff/1/2
> File src/mobility/steady-state-random-waypoint-mobility-model.cc (right):
>
> http://codereview.appspot.com/193105/diff/1/2#newcode121
> src/mobility/steady-state-random-waypoint-mobility-model.cc:121: if(v0 == v1)
> missing braces around single-line statements
I've added test to steady-state RWP model. This test compares distributions
(mean value and standard deviation) of speeds and positions of 10000 nodes in
the beginning of their moving and after 1000 seconds.
On Thu, Jan 28, 2010 at 4:09 PM, <Fahriev.Denis@gmail.com> wrote: > I've added test to ...
14 years, 1 month ago
(2010-01-29 08:56:51 UTC)
#3
On Thu, Jan 28, 2010 at 4:09 PM, <Fahriev.Denis@gmail.com> wrote:
> I've added test to steady-state RWP model. This test compares
> distributions (mean value and standard deviation) of speeds and
> positions of 10000 nodes in the beginning of their moving and after 1000
> seconds.
>
So Totally Cool !
+1 for merging.
Mathieu
--
Mathieu Lacage <mathieu.lacage@gmail.com>
Issue 193105: Steady State Random Waypoint Mobility Model
Created 14 years, 1 month ago by Fahriev.Denis
Modified 14 years, 1 month ago
Reviewers: Mathieu Lacage
Base URL:
Comments: 1