random-variable - doc updated and new Zeta distribution

Closed issue, merged with ns-3-dev

[Mathieu Lacage, 2010-01-23 17:39:16]

looks good modulo very minor style details. you might find the check-style.py
script helpful. Also, please file a bug to keep track of this issue.

http://codereview.appspot.com/193060/diff/1/2
File src/core/random-variable.cc (right):

http://codereview.appspot.com/193060/diff/1/2#newcode1600
src/core/random-variable.cc:1600: class ZetaVariableImpl : public
RandomVariableBase {
should be instead:
class ZetaVariableImpl : public RandomVariableBase
{

http://codereview.appspot.com/193060/diff/1/2#newcode1630
src/core/random-variable.cc:1630: :m_alpha(3.14), m_b(pow(2.0, 2.14))
missing 2-space indent at start of line.

http://codereview.appspot.com/193060/diff/1/2#newcode1636
src/core/random-variable.cc:1636: :m_alpha(alpha), m_b(pow(2.0, alpha-1.0))
same here

http://codereview.appspot.com/193060/diff/1/2#newcode1648
src/core/random-variable.cc:1648: if(!m_generator)
indent

http://codereview.appspot.com/193060/diff/1/2#newcode1658
src/core/random-variable.cc:1658: u = m_generator->RandU01();
indent

http://codereview.appspot.com/193060/diff/1/2#newcode1662
src/core/random-variable.cc:1662: } while (v*X*(T-1.0)/(m_b-1.0) > T/m_b );
that condition looks pretty scary. I would assign the left member to a local
variable above before doing the test.

[Tommaso Pecorella, 2010-01-23 21:53:51]

Done, I'll reupload everything later tonight.

Both random-variable.cc and random-variable.h had more indentation and such
mistakes. I corrected all.
Btw, that check-style.py rocks big time. I had a bit of troubles finding it tho
(St. Google helped). Maybe you should point to it in the ns-3 wiki pages.

My problem with filling bug reports is that it seems that I am known by
different systems with 3 different e-mails, so automatic cc emails seems to get
a bit confused about who I am :P

Anyway, I'll sort out my emails. The important thing is that people doesn't get
confused :)

Best regards,

Tommaso


On 23/gen/2010, at 18.39, mathieu.lacage@gmail.com wrote:

> looks good modulo very minor style details. you might find the
> check-style.py script helpful. Also, please file a bug to keep track of
> this issue.
> 
> 
> http://codereview.appspot.com/193060/diff/1/2
> File src/core/random-variable.cc (right):
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1600
> src/core/random-variable.cc:1600: class ZetaVariableImpl : public
> RandomVariableBase {
> should be instead:
> class ZetaVariableImpl : public RandomVariableBase
> {
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1630
> src/core/random-variable.cc:1630: :m_alpha(3.14), m_b(pow(2.0, 2.14))
> missing 2-space indent at start of line.
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1636
> src/core/random-variable.cc:1636: :m_alpha(alpha), m_b(pow(2.0,
> alpha-1.0))
> same here
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1648
> src/core/random-variable.cc:1648: if(!m_generator)
> indent
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1658
> src/core/random-variable.cc:1658: u = m_generator->RandU01();
> indent
> 
> http://codereview.appspot.com/193060/diff/1/2#newcode1662
> src/core/random-variable.cc:1662: } while (v*X*(T-1.0)/(m_b-1.0) > T/m_b
> );
> that condition looks pretty scary. I would assign the left member to a
> local variable above before doing the test.
> 
> http://codereview.appspot.com/193060/show

[Tommaso Pecorella, 2010-01-24 02:36:07]

Dammit, I forgot to update the revisions number, so there are two spurious files
in the patch.

.hgtags and bindings/python/ns3modulegen.py are simply the latest two change
sets to 3.7RC4. Sorry for the inconvenience.

Tommaso

[Tommaso Pecorella, 2010-01-24 02:49:24]

Opened a bug to keep track of this patch: 
Bug 797