Issue 1929041: Build: fix 1167.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1929041: Build: fix 1167. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Graham Percival (old account)

Modified:
13 years, 8 months ago

Reviewers:
MikeSol

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Build: fix 1167. I think it works. It doesn't seem to mess up the offline build, at least. I'm not 100% certain about the exact url, but it definitely changes the url, so I guess we'll just have to wait until 2.13.30 to see if it really works or not?

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix for 1115 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	scripts/auxiliar/makelsr.py	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

MikeSol

13 years, 8 months ago (2010-08-09 15:39:55 UTC) #1

http://codereview.appspot.com/1929041/diff/1/2
File python/auxiliar/postprocess_html.py (right):

http://codereview.appspot.com/1929041/diff/1/2#newcode353
python/auxiliar/postprocess_html.py:353:
'href=\"../../../website/development.html\"')
s.replace does a greedy search for strings and replaces them.
For your purposes s.replace looks fine.  To make it gel w/ the re stuff in the
rest of the file, you can use re.sub, as in the unfortuantely-line-wrapped
snippet below (the three long statements to the python interpreter should not
have a newline):

>>> import re
>>> a = re.compile('href=\"../..//Documentation/web/manuals.html\"')
>>> z = 'foo href=\"../..//Documentation/web/manuals.html\" bar
href=\"../..//Documentation/web/manuals.html\"'
>>> re.sub(a,'href=\"../../../website/development.html\"',z)
'foo href="../../../website/development.html" bar
href="../../../website/development.html"'

Expand All Messages | Collapse All Messages