Issue 192190043: Web: use CSS gradient backgrounds for headings

Issue 192190043: Web: use CSS gradient backgrounds for headings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by pwm

Modified:
9 years, 3 months ago

Reviewers:
davide.liessi

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Web: use CSS gradient backgrounds for headings Provide image fallbacks for IE9 and lower via separate, conditionally included CSS file.

Patch Set 1 #

Total comments: 3

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -10 lines)			Patch
A +	Documentation/css/lilypond-manuals-ie-fixes.css	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Documentation/css/lilypond-website.css	View	6 chunks	+29 lines, -7 lines	0 comments	Download
A	Documentation/css/lilypond-website-ie-fixes.css	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	Documentation/lilypond-texi2html.init	View	2 chunks	+7 lines, -4 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

davide.liessi

https://codereview.appspot.com/192190043/diff/1/Documentation/lilypond-texi2html.init File Documentation/lilypond-texi2html.init (right): https://codereview.appspot.com/192190043/diff/1/Documentation/lilypond-texi2html.init#newcode1222 Documentation/lilypond-texi2html.init:1222: "\n"; Aren't 'website' ...

9 years, 3 months ago (2015-01-07 08:42:10 UTC) #2

pwm

9 years, 3 months ago (2015-01-07 13:27:13 UTC) #3

davide.liessi

9 years, 3 months ago (2015-01-07 16:15:14 UTC) #4

https://codereview.appspot.com/192190043/diff/1/Documentation/lilypond-texi2h...
File Documentation/lilypond-texi2html.init (right):

https://codereview.appspot.com/192190043/diff/1/Documentation/lilypond-texi2h...
Documentation/lilypond-texi2html.init:1222: "<!--[if lte IE 9]>\n<link
href=\"css/lilypond-website-ie-fixes.css\" rel=\"stylesheet\"
type=\"text/css\">\n<![endif]-->\n";
On 2015/01/07 13:27:13, pwm wrote:
> On 2015/01/07 08:42:10, davide.liessi wrote:
> > Aren't 'website' and 'manuals' inverted here?
> 
> No, although the order in the code (if $web_manual ...website-ie-fixes.css
else
> ...manuals-ie-fixes.css) is the reverse of the comment "...the docs or the
> website".  So the comment could be changed for more consistency.

I'm sorry, I misunderstood the meaning of the $web_manual variable.
No need to change the comment, in my opinion: I was mislead by my wrong
assumptions, not by the comment.

Expand All Messages | Collapse All Messages