13 years, 8 months ago
(2010-08-03 23:38:48 UTC)
#2
http://codereview.appspot.com/1918042/diff/1/2
File Lib/test/test_urllib.py (right):
http://codereview.appspot.com/1918042/diff/1/2#newcode1090
Lib/test/test_urllib.py:1090: def test_a_wrapped_url(self):
On 2010/08/03 23:28:39, merwok wrote:
> It’s not usual to put an article in a method name. test_wrapped_url would do.
> (I’d even say uri, but well :)
I'm used to a more BDD style of testing where each test is actually a sentence
describing the test.
http://codereview.appspot.com/1918042/diff/1/3
File Lib/urllib/request.py (right):
http://codereview.appspot.com/1918042/diff/1/3#newcode166
Lib/urllib/request.py:166: self.full_url, garbage = splittag(self.full_url)
On 2010/08/03 23:28:39, merwok wrote:
> PEP 8 recommends using “_” for an object you want to discard.
The only reason I picked the name 'garbage' was to match the style of the file.
It is used elsewhere for the same purpose.
Issue 1918042: urllib2 passes fragment identifier to the server
Created 13 years, 8 months ago by dstanek
Modified 13 years, 4 months ago
Reviewers: merwok
Base URL:
Comments: 6