Issue 1910047: Replaced __inline with inline to make it compile with SunStudio compiler. Sub...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1910047: Replaced __inline with inline to make it compile with SunStudio compiler. Sub... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by Alok Priyadarshi

Modified:
15 years, 5 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Replaced __inline with inline to make it compile with SunStudio compiler. Submitted by Eagle.Lu. BUG=19

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/compiler/BaseTypes.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4

dgkoch

Patch looks fine. Should we add Eagle.lu to the CONTRIBUTORS file?

15 years, 5 months ago (2010-08-06 02:33:43 UTC) #3

Alok Priyadarshi

15 years, 5 months ago (2010-08-09 17:13:52 UTC) #4

> 
> Should we add Eagle.lu to the CONTRIBUTORS file?

Yes if our policy is to add everyone submitting a patch.