Issue 190102: Avoid orphan/widow lines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 190102: Avoid orphan/widow lines

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by Boris Shingarov

Modified:
14 years, 3 months ago

Reviewers:
joeneeman

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Patch Set 1 #

Total comments: 8

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -3 lines)			Patch
M	lily/constrained-breaking.cc	View	2 chunks	+5 lines, -1 line	4 comments	Download
M	lily/include/constrained-breaking.hh	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	lily/include/page-breaking.hh	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	lily/page-breaking.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	lily/page-spacing.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	lily/paper-book.cc	View	2 chunks	+20 lines, -2 lines	4 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

joeneeman

lgtm, modulo some more formatting nitpicking. If you fix the formatting and mail me the ...

14 years, 3 months ago (2010-01-21 20:45:06 UTC) #2

b1_shingarov.com

> lgtm, modulo some more formatting nitpicking. If you fix the formatting > and mail ...

14 years, 3 months ago (2010-01-21 21:23:38 UTC) #3

Boris Shingarov

14 years, 3 months ago (2010-01-21 23:02:15 UTC) #4

http://codereview.appspot.com/190102/diff/1/2
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/190102/diff/1/2#newcode529
lily/constrained-breaking.cc:529: last_markup_line_  = to_boolean(last_scm);
On 2010/01/21 20:45:06, joeneeman wrote:
> space before (

Done.

http://codereview.appspot.com/190102/diff/1/2#newcode531
lily/constrained-breaking.cc:531: first_markup_line_ = to_boolean(first_scm);
On 2010/01/21 20:45:06, joeneeman wrote:
> space before (

Done.

http://codereview.appspot.com/190102/diff/1/7
File lily/paper-book.cc (right):

http://codereview.appspot.com/190102/diff/1/7#newcode554
lily/paper-book.cc:554: {
On 2010/01/21 20:45:06, joeneeman wrote:
> indentation should be
> if (blah)
>   {
>     foo();
>   }
> 

Done.

http://codereview.appspot.com/190102/diff/1/7#newcode558
lily/paper-book.cc:558: ps->set_property ("first-markup-line",	SCM_BOOL_F);
On 2010/01/21 20:45:06, joeneeman wrote:
> extra spaces?

Done.

Expand All Messages | Collapse All Messages