Yet another fix to the P & N copying code for displacement to make the interpreter and LLVM work the same way -- don't "find" the symbol from a layer that never was bound.
Actually, it's even easier. Instead of if (exec.instance() && exec.bound()) { it's ok to just ...
14 years, 9 months ago
(2010-08-02 18:41:45 UTC)
#3
Actually, it's even easier. Instead of
if (exec.instance() && exec.bound()) {
it's ok to just test
if (exec.bound()) {
Bound implies that there is a good instance pointer, not the other way around
necessarily. That was my mistake all along.
On 2010/08/02 18:41:45, larrygritz wrote: > Actually, it's even easier. Instead of > > if ...
14 years, 9 months ago
(2010-08-02 18:45:42 UTC)
#4
On 2010/08/02 18:41:45, larrygritz wrote:
> Actually, it's even easier. Instead of
>
> if (exec.instance() && exec.bound()) {
>
> it's ok to just test
>
> if (exec.bound()) {
>
> Bound implies that there is a good instance pointer, not the other way around
> necessarily. That was my mistake all along.
LGTM
Issue 1897048: Review: displacement bug fix
(Closed)
Created 14 years, 9 months ago by larrygritz
Modified 14 years, 9 months ago
Reviewers: clifford.stein
Base URL: http://openshadinglanguage.googlecode.com/svn/trunk/
Comments: 0