Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 1897048: Review: displacement bug fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by larrygritz
Modified:
13 years, 9 months ago
Reviewers:
clifford.stein
CC:
osl-dev_googlegroups.com, dev-osl_imageworks.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Yet another fix to the P & N copying code for displacement to make the interpreter and LLVM work the same way -- don't "find" the symbol from a layer that never was bound.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
src/liboslexec/context.cpp View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/oslexec_pvt.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
larrygritz
13 years, 9 months ago (2010-08-02 18:19:05 UTC) #1
clifford.stein
On 2010/08/02 18:19:05, larrygritz wrote: > LGTM
13 years, 9 months ago (2010-08-02 18:41:39 UTC) #2
larrygritz
Actually, it's even easier. Instead of if (exec.instance() && exec.bound()) { it's ok to just ...
13 years, 9 months ago (2010-08-02 18:41:45 UTC) #3
clifford.stein
13 years, 9 months ago (2010-08-02 18:45:42 UTC) #4
On 2010/08/02 18:41:45, larrygritz wrote:
> Actually, it's even easier.  Instead of
> 
>  if (exec.instance() && exec.bound()) {
> 
> it's ok to just test
> 
>  if (exec.bound()) {
> 
> Bound implies that there is a good instance pointer, not the other way around
> necessarily.  That was my mistake all along.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b