Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(579)

Issue 1894042: Review: LLVM displacement bug fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by larrygritz
Modified:
13 years, 8 months ago
Reviewers:
clifford.stein
CC:
osl-dev_googlegroups.com, dev-osl_imageworks.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In the course of the merge, I broke displacement subtly when not using LLVM. This patch copies out P and N correctly for the interpreter, as we do for the LLVM path, so that the renderer on the other end can count on it working the same whichever way is in effect.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
src/liboslexec/context.cpp View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2
larrygritz
13 years, 8 months ago (2010-07-24 06:10:31 UTC) #1
clifford.stein
13 years, 8 months ago (2010-07-26 16:38:03 UTC) #2
On 2010/07/24 06:10:31, larrygritz wrote:
> 

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b