Issue 1890044: Create ly:grob-chain-callback from chain_callback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1890044: Create ly:grob-chain-callback from chain_callback (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by MikeSol

Modified:
13 years ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Create ly:grob-chain-callback from chain_callback Create ly:grob-chain-callback from chain_callback Whitespace fix

Patch Set 2 : Assertion fixes for ly:grob-chain-callback #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	lily/grob-scheme.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Neil Puttock

http://codereview.appspot.com/1890044/diff/1/2 File lily/grob-scheme.cc (right): http://codereview.appspot.com/1890044/diff/1/2#newcode407 lily/grob-scheme.cc:407: 3, 0, 0, (SCM grob, SCM proc, SCM sym), ...

13 years, 8 months ago (2010-08-04 18:50:58 UTC) #1

MikeSol

13 years, 8 months ago (2010-08-04 20:17:40 UTC) #2

LGTM, pushed to master.

Cheers,
Neil

Expand All Messages | Collapse All Messages