Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1985)

Issue 1888042: Fix 442. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by joeneeman
Modified:
13 years, 8 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 442. Add an engraver which keeps all of the staves below it alive together.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -0 lines) Patch
A input/regression/hara-kiri-alive-with.ly View 1 chunk +23 lines, -0 lines 0 comments Download
M lily/hara-kiri-group-spanner.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M lily/include/hara-kiri-group-spanner.hh View 1 chunk +1 line, -0 lines 0 comments Download
A lily/keep-alive-together-engraver.cc View 1 chunk +80 lines, -0 lines 1 comment Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 2
Neil Puttock
Hi Joe, LGTM. I'd be quite happy with this method, even though it loses a ...
13 years, 8 months ago (2010-08-04 21:57:20 UTC) #1
joeneeman
13 years, 8 months ago (2010-08-06 21:57:28 UTC) #2
On 2010/08/04 21:57:20, Neil Puttock wrote:
> Hi Joe,
> 
> LGTM.
> 
> I'd be quite happy with this method, even though it loses a bit of flexibility
> in comparison with your original patch.

Thanks, fixed and pushed. I don't particularly see much use for the original
flexibility, but we can always add it on later. It would just be a new interface
anyway to the same backend code anyway.

Cheers,
Joe
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b