Issue 1879042: Added <stdio.h> include for sprintf. It broke Chrome downstream when I bumped...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1879042: Added <stdio.h> include for sprintf. It broke Chrome downstream when I bumped...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by apatrick1

Modified:
13 years, 11 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added <stdio.h> include for sprintf. It broke Chrome downstream when I bumped the rev.

Patch Set 1 #

Total comments: 1

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/compiler/OutputHLSL.cpp	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

13 years, 11 months ago (2010-07-20 20:17:39 UTC) #2

lgtm

http://codereview.appspot.com/1879042/diff/1/2
File src/compiler/OutputHLSL.cpp (right):

http://codereview.appspot.com/1879042/diff/1/2#newcode19
src/compiler/OutputHLSL.cpp:19: TString str(int i)
I thought we were using TStringStream to do these conversions.

Expand All Messages | Collapse All Messages