Issue 1878044: De-allocate memory in ShFinalize(). There still seems to be a bug here if the...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1878044: De-allocate memory in ShFinalize(). There still seems to be a bug here if the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Alok Priyadarshi

Modified:
13 years, 9 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

De-allocate memory in ShFinalize(). There still seems to be a bug here if the translator is used in a multi-threaded environment. It seems memory local to only one thread is being deallocated - the thread from which ShFinalize() is called. I will look into it closely in the next CL.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -80 lines)			Patch
M	src/compiler/InitializeDll.h	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/compiler/InitializeDll.cpp	View	1 2	2 chunks	+45 lines, -50 lines	0 comments	Download
M	src/compiler/InitializeParseContext.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/compiler/ParseHelper.cpp	View		3 chunks	+21 lines, -20 lines	0 comments	Download
M	src/compiler/ShaderLang.cpp	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

http://codereview.appspot.com/1878044/diff/1/2 File src/compiler/InitializeDll.cpp (right): http://codereview.appspot.com/1878044/diff/1/2#newcode94 src/compiler/InitializeDll.cpp:94: FreeGlobalPools(); I will replace tabs before submitting, which will ...

13 years, 9 months ago (2010-07-26 21:00:39 UTC) #1

no issues here

Expand All Messages | Collapse All Messages