Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 187770044: TBR: Add new code review front end: "git review"

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by bruening
Modified:
11 years, 5 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Add new code review front end: "git review" Adds an alias "git review" that calls a new script git_review.sh. It provides simple updates of new patchsets to the same review, commit message reviewing by uploading the precise message for each patchset, and auto-adding of the review URL to the commit message. The existing "git dcommit" now also calls git_review.sh to mark the review as committed with its final diff and a pointer to the online commit, as well as remove the current review issue marker. ---------------

Patch Set 1 #

Patch Set 2 : Example of a second patchset with a change #

Patch Set 3 : Third patchset #

Patch Set 4 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1 line) Patch
M make/git/devsetup.sh View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A make/git/git_review.sh View 1 chunk +157 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bruening
11 years, 5 months ago (2014-12-06 16:22:36 UTC) #1
bruening
Commit log for latest patchset: --------------- Add new code review front end: "git review" Adds ...
11 years, 5 months ago (2014-12-06 16:26:20 UTC) #2
bruening
Commit log for latest patchset: --------------- Add new code review front end: "git review" Adds ...
11 years, 5 months ago (2014-12-06 16:27:03 UTC) #3
bruening
11 years, 5 months ago (2014-12-06 16:27:30 UTC) #4
Committed as
https://github.com/DynamoRIO/dynamorio/commit/a6ed90816b7c1ccad10a98e40c293e6...

Final commit log: 
---------------
Add new code review front end: "git review"

Adds an alias "git review" that calls a new script git_review.sh.  It
provides simple updates of new patchsets to the same review, commit message
reviewing by uploading the precise message for each patchset, and
auto-adding of the review URL to the commit message.

The existing "git dcommit" now also calls git_review.sh to mark the review
as committed with its final diff and a pointer to the online commit, as
well as remove the current review issue marker.

Review-URL: https://codereview.appspot.com/187770044
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b