Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2322)

Issue 1876042: Fix closure merge for external defined ones (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by aconty
Modified:
13 years, 2 months ago
Reviewers:
dev-osl, osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I forgot to cover the case of external closures in the merge code for ADD. This patch fixes the problem.

Patch Set 1 #

Patch Set 2 : fixed stupid mistake #

Patch Set 3 : Added support for merging external closures too #

Patch Set 4 : support for llvm side which I forgot in the previous patch #

Total comments: 4

Patch Set 5 : Addressed comments #

Total comments: 2

Patch Set 6 : Addressed comments and debug clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -41 lines) Patch
src/include/oslclosure.h View 1 2 3 4 5 3 chunks +9 lines, -7 lines 0 comments Download
src/include/oslexec.h View 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
src/liboslexec/builtin_closures.cpp View 3 4 5 3 chunks +11 lines, -2 lines 0 comments Download
src/liboslexec/closure.cpp View 1 2 3 4 5 4 chunks +14 lines, -12 lines 0 comments Download
src/liboslexec/closure_test.cpp View 3 4 5 4 chunks +18 lines, -3 lines 0 comments Download
src/liboslexec/llvm_instance.cpp View 4 5 1 chunk +6 lines, -1 line 0 comments Download
src/liboslexec/llvm_ops.cpp View 4 5 1 chunk +3 lines, -2 lines 0 comments Download
src/liboslexec/opmath.cpp View 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
src/liboslexec/oslexec_pvt.h View 3 4 5 3 chunks +12 lines, -4 lines 0 comments Download
src/liboslexec/shadingsys.cpp View 3 4 5 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10
aconty
13 years, 8 months ago (2010-07-22 17:30:45 UTC) #1
aconty
Added support for merging external closures too
13 years, 8 months ago (2010-07-30 16:38:46 UTC) #2
aconty
support for llvm side which I forgot in the previous patch
13 years, 8 months ago (2010-07-30 17:29:46 UTC) #3
ckulla
http://codereview.appspot.com/1876042/diff/15001/16001 File src/include/oslclosure.h (right): http://codereview.appspot.com/1876042/diff/15001/16001#newcode583 src/include/oslclosure.h:583: int memsize; ///< Memory size of the component This ...
13 years, 8 months ago (2010-07-30 18:03:33 UTC) #4
aconty
Addressed comments
13 years, 8 months ago (2010-07-31 00:14:17 UTC) #5
ckulla
LGTM, just a few small notes. http://codereview.appspot.com/1876042/diff/31001/32004 File src/liboslexec/closure.cpp (right): http://codereview.appspot.com/1876042/diff/31001/32004#newcode95 src/liboslexec/closure.cpp:95: CompareClosureFunc compare = ...
13 years, 8 months ago (2010-07-31 01:28:52 UTC) #6
aconty
Got it, I'll fix all these problems.
13 years, 8 months ago (2010-08-02 16:30:14 UTC) #7
aconty
Addressed comments and debug clean up
13 years, 8 months ago (2010-08-02 16:31:29 UTC) #8
ckulla
On 2010/08/02 16:31:29, aconty wrote: > Addressed comments and debug clean up LGTM
13 years, 8 months ago (2010-08-02 17:36:51 UTC) #9
aconty
13 years, 8 months ago (2010-08-02 17:45:41 UTC) #10
checked in to r791
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b