Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(876)

Issue 186640043: Doc: Clarified how to use clip-systems option (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by pkx166h
Modified:
9 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Clarified how to use clip-systems option Issue 4219 Improved explanation of how to extract music fragments in the NR and the corresponding clip-systems option in Usage. Added some @cindex and @funindex as well as some @seealso.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Jean-Charles and Thomas M's corrections plus some rewrite of awkwardly phrased passages. #

Patch Set 3 : Fix compilation issue in TexInfo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -21 lines) Patch
M Documentation/notation/input.itely View 1 2 1 chunk +34 lines, -20 lines 1 comment Download
M Documentation/usage/running.itely View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8
thomasmorley651
One nitpick, otherwise LGTM https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2541 Documentation/notation/input.itely:2541: This will extract a single ...
9 years, 3 months ago (2015-01-02 13:53:59 UTC) #1
Jean-Charles
just one nitpick, otherwise LGTM. https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2559 Documentation/notation/input.itely:2559: @ref{The layout block,,The @code{@bs{}layout} ...
9 years, 3 months ago (2015-01-02 14:29:17 UTC) #2
pkx166h
Jean-Charles and Thomas M's corrections plus some rewrite of awkwardly phrased passages.
9 years, 3 months ago (2015-01-04 12:05:53 UTC) #3
pkx166h
Thanks https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2541 Documentation/notation/input.itely:2541: This will extract a single fragment of the ...
9 years, 3 months ago (2015-01-04 12:06:29 UTC) #4
thomasmorley651
LGTM
9 years, 3 months ago (2015-01-04 13:42:07 UTC) #5
pkx166h
Fix compilation issue in TexInfo
9 years, 3 months ago (2015-01-04 21:40:22 UTC) #6
Jean-Charles
Sorry to come so late https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely#newcode2543 Documentation/notation/input.itely:2543: (@code{5 1 2}) and ...
9 years, 3 months ago (2015-01-11 17:43:04 UTC) #7
pkx166h
9 years, 3 months ago (2015-01-11 22:50:36 UTC) #8
On 2015/01/11 17:43:04, Jean-Charles wrote:
> Sorry to come so late
> 
>
https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/in...
> File Documentation/notation/input.itely (right):
> 
>
https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/in...
> Documentation/notation/input.itely:2543: (@code{5 1 2}) and @emph{ending}
after
> three, quarter notes in the
> to avoid the comma and any ambiguity:
> after the third quarter note…

I'd already pushed this, but have pushed the minor correction.

author	James Lowe <pkx166h@gmail.com>	
	Sun, 11 Jan 2015 22:45:40 +0000 (22:45 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 11 Jan 2015 22:45:40 +0000 (22:45 +0000)
commit	7b4cd7b6b3bc0f905e4143120440b40c940c1fdc

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b