Remove cursor, user and context instead use a Transaction

[timitos, 2010-07-26 06:17:54]

http://codereview.appspot.com/1864045/diff/1/15
File trytond/ir/cron.py (right):

http://codereview.appspot.com/1864045/diff/1/15#newcode190
trytond/ir/cron.py:190: cursor.rollback()
transaction.cursor.rollback()

http://codereview.appspot.com/1864045/diff/1/24
File trytond/ir/translation.py (right):

http://codereview.appspot.com/1864045/diff/1/24#newcode379
trytond/ir/translation.py:379: ctx = context.copy()
patch is only working with english database for the moment as here is an old
context expression.

http://codereview.appspot.com/1864045/diff/1/49
File trytond/security.py (right):

http://codereview.appspot.com/1864045/diff/1/49#newcode7
trytond/security.py:7: from trytond.transaction import Transaction
from __future__ import with_statement

[timitos, 2010-07-26 20:01:09]

works for me now

[timitos, 2010-07-26 20:04:47]

http://codereview.appspot.com/1864045/diff/8001/9065
File trytond/workflow/workflow.py (right):

http://codereview.appspot.com/1864045/diff/8001/9065#newcode522
trytond/workflow/workflow.py:522: if context is None:
can this be removed?

[timitos, 2010-07-27 05:39:12]

found this in my server log:

Traceback (most recent call last):
  File "/home/kp/tryton/dev/trytond/trytond/protocols/dispatcher.py", line 136,
in dispatch
    res = getattr(obj, method)(*args, **kargs)
  File "/home/kp/tryton/dev/trytond/trytond/ir/ui/view.py", line 323, in
set_width
    ('user', '=', user),
NameError: global name 'user' is not defined

[bch, 2010-07-27 07:01:45]

http://codereview.appspot.com/1864045/diff/8001/9013
File trytond/ir/attachment.py (right):

http://codereview.appspot.com/1864045/diff/8001/9013#newcode43
trytond/ir/attachment.py:43: table = TableHandler(cursor, self, module_name)
What about using Transaction() in TableHandler (and so avoid to pass cursor as
param.)?

[ced, 2010-07-27 07:11:25]

http://codereview.appspot.com/1864045/diff/8001/9013
File trytond/ir/attachment.py (right):

http://codereview.appspot.com/1864045/diff/8001/9013#newcode43
trytond/ir/attachment.py:43: table = TableHandler(cursor, self, module_name)
On 2010/07/27 07:01:45, bch wrote:
> What about using Transaction() in TableHandler (and so avoid to pass cursor as
> param.)?

Because TableHandler comes from trytond.backend and it should be imported before
Transaction.

[paepke, 2010-07-29 20:11:23]

got the following traceback:
Traceback (most recent call last):
  File "/trytond/protocols/netrpc.py", line 47, in run
    res = dispatch(host, port, 'NetRPC', *msg)
  File "/trytond/protocols/dispatcher.py", line 136, in dispatch
    res = getattr(obj, method)(*args, **kargs)
  File "/trytond/model/modelsql.py", line 432, in read
    domain1, domain2 = rule_obj.domain_get(self._name, mode='read')
  File "/trytond/tools/misc.py", line 261, in call
    result = function(model, *args, **kwargs_origin)
  File "/trytond/ir/rule.py", line 204, in domain_get
    clause[rule.rule_group.id].append(dom)
  File "/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "/contextlib.py", line 113, in nested
    yield vars
  File "/trytond/ir/rule.py", line 194, in domain_get
    operand2query[rule.operand]), {
KeyError: u'User/Groups'

[ced, 2010-07-30 07:18:53]

On 2010/07/29 20:11:23, paepke wrote:
> got the following traceback:
> Traceback (most recent call last):
>   File "/trytond/protocols/netrpc.py", line 47, in run
>     res = dispatch(host, port, 'NetRPC', *msg)
>   File "/trytond/protocols/dispatcher.py", line 136, in dispatch
>     res = getattr(obj, method)(*args, **kargs)
>   File "/trytond/model/modelsql.py", line 432, in read
>     domain1, domain2 = rule_obj.domain_get(self._name, mode='read')
>   File "/trytond/tools/misc.py", line 261, in call
>     result = function(model, *args, **kwargs_origin)
>   File "/trytond/ir/rule.py", line 204, in domain_get
>     clause[rule.rule_group.id].append(dom)
>   File "/contextlib.py", line 34, in __exit__
>     self.gen.throw(type, value, traceback)
>   File "/contextlib.py", line 113, in nested
>     yield vars
>   File "/trytond/ir/rule.py", line 194, in domain_get
>     operand2query[rule.operand]), {
> KeyError: u'User/Groups'

I can not reproduce.

[timitos, 2010-07-30 08:46:54]

On 2010/07/30 07:18:53, ced wrote:
> On 2010/07/29 20:11:23, paepke wrote:
> > got the following traceback:
> > Traceback (most recent call last):
> >   File "/trytond/protocols/netrpc.py", line 47, in run
> >     res = dispatch(host, port, 'NetRPC', *msg)
> >   File "/trytond/protocols/dispatcher.py", line 136, in dispatch
> >     res = getattr(obj, method)(*args, **kargs)
> >   File "/trytond/model/modelsql.py", line 432, in read
> >     domain1, domain2 = rule_obj.domain_get(self._name, mode='read')
> >   File "/trytond/tools/misc.py", line 261, in call
> >     result = function(model, *args, **kwargs_origin)
> >   File "/trytond/ir/rule.py", line 204, in domain_get
> >     clause[rule.rule_group.id].append(dom)
> >   File "/contextlib.py", line 34, in __exit__
> >     self.gen.throw(type, value, traceback)
> >   File "/contextlib.py", line 113, in nested
> >     yield vars
> >   File "/trytond/ir/rule.py", line 194, in domain_get
> >     operand2query[rule.operand]), {
> > KeyError: u'User/Groups'
> 
> I can not reproduce.

I can reproduce this with german as language but not with english.

[paepke, 2010-07-30 10:14:10]

On 2010/07/30 10:08:24, ced wrote:
> 

had just tested it. can confirm with german vs. english
ced, your patch fixed it.