The class is named inappropriately, as it does even do any decoding. It is renamed to codec to capture both encoding/decoding work for gadget security tokens.
LGTM Please also update the UPGRADING file and explain the rename since we might break ...
15 years, 2 months ago
(2010-07-22 00:12:15 UTC)
#2
LGTM
Please also update the UPGRADING file and explain the rename since we might
break anyone that derive from the class.
Paul, is there a reason we should not rename it at this point of time?
if not I will submit.
On 2010/07/22 00:12:15, zhoresh wrote: > LGTM > > Please also update the UPGRADING file ...
15 years, 2 months ago
(2010-07-22 00:37:51 UTC)
#5
On 2010/07/22 00:12:15, zhoresh wrote:
> LGTM
>
> Please also update the UPGRADING file and explain the rename since we might
> break anyone that derive from the class.
>
Done. Re-uploaded patch. All tests passed.
> Paul, is there a reason we should not rename it at this point of time?
> if not I will submit.
Thanks Paul. I was thinking to reuse the old names and create simple derived classes/interface ...
15 years, 2 months ago
(2010-07-22 02:50:01 UTC)
#6
Thanks Paul. I was thinking to reuse the old names and create simple derived
classes/interface to make it backward compatible. But I think it won't work due
to the interface.
Submitted r966481
Issue 1864043: Rename SecurityTokenDecoder to SecurityTokenCodec
(Closed)
Created 15 years, 2 months ago by mhermanto
Modified 15 years, 2 months ago
Reviewers: zhoresh, Paul Lindner
Base URL: http://svn.apache.org/repos/asf/shindig/trunk/
Comments: 0