Issue 1863048: Make WITH_CLEANUP have a determinstic effect on stack level.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1863048: Make WITH_CLEANUP have a determinstic effect on stack level. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by ebo

Modified:
15 years ago

Reviewers:
Reid Kleckner

CC:
unladen-swallow_googlegroups.com

Base URL:
http://unladen-swallow.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Whitespace cleanup #

Total comments: 1

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -133 lines)			Patch
M	JIT/llvm_fbuilder.cc	View		2 chunks	+23 lines, -5 lines	0 comments	Download
M	JIT/opcodes/block.cc	View		7 chunks	+38 lines, -89 lines	0 comments	Download
M	Lib/compiler/pycodegen.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	Python/compile.c	View		4 chunks	+6 lines, -2 lines	0 comments	Download
M	Python/eval.cc	View	1	6 chunks	+32 lines, -36 lines	1 comment	Download
M	Python/import.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ebo

Someone gave me a patch to make the WITH_CLEANUP opcode behave better. I updated it ...

15 years ago (2010-07-29 18:58:39 UTC) #1

Reid Kleckner

15 years ago (2010-07-29 20:08:07 UTC) #2

LGTM

Awesome!  Are there any other of these variable stack adjustment opcodes, or is
this all?

We could alter the way we generate IR to use only GEPs from the base stack
pointer if this is the case, but it would be a lot of work and would disrupt the
similarity between the JIT's opcode dispatch and the eval loop's.  Hopefully
LLVM will just fold away the redundant stack pointer GEPs now that there are no
phi nodes in the way.

We should also check if this produces a speedup or slowdown, but I wouldn't
expect it to have much impact.

http://codereview.appspot.com/1863048/diff/2001/3003
File Python/eval.cc (right):

http://codereview.appspot.com/1863048/diff/2001/3003#newcode3125
Python/eval.cc:3125: else
The Python style is:
    ...
}
else {
    ...

Not that it really matters.  :)

Expand All Messages | Collapse All Messages