Issue 186248: skia: Always use aliased text when antialiasing is disabled....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186248: skia: Always use aliased text when antialiasing is disabled.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by derat

Modified:
14 years, 4 months ago

Reviewers:
agl1, agl

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/src/

Visibility:
Public.

Description

skia: Always use aliased text when antialiasing is disabled. Otherwise, people who have antialiasing disabled end up with subpixel rendering if the subpixel setting happens to be set to something other than "none". This change's interpretation of these overlapping settings seems to be consistent with GTK's and Firefox's. BUG=http://code.google.com/p/chromium/issues/detail?id=28382

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	core/SkPaint.cpp	View		1 chunk	+7 lines, -6 lines	0 comments	Download
	M	ports/SkFontHost_FreeType.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

On 2010/01/20 22:38:12, agl1 wrote: > LGTM. I can land tomorrow unless reed beats me ...

14 years, 5 months ago (2010-01-21 11:44:09 UTC) #3

derat

14 years, 5 months ago (2010-01-21 16:02:39 UTC) #4

On Thu, Jan 21, 2010 at 3:44 AM,  <agl@golang.org> wrote:
> On 2010/01/20 22:38:12, agl1 wrote:
>>
>> LGTM. I can land tomorrow unless reed beats me to it.
>
> Commited as r475. I haven't rolled DEPS however.

Thanks, I'll do it today.

> http://codereview.appspot.com/186248/show
>

Expand All Messages | Collapse All Messages