Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(822)

Issue 186112: Fix DynamicTextSpanner left alignment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Neil Puttock
Modified:
14 years, 4 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix DynamicTextSpanner left alignment. When a DynamicTextSpanner directly follows a DynamicScript, padding is required to ensure the 'left 'text doesn't collide with the dynamic sign. Unfortunately, this default value skews the spanner's left bound to the right when no dynamic script is present. This patch caters for both situations by resetting 'left 'padding and 'left 'attach-dir as required, adding extra padding read from the property 'right-padding to fine-tune the space between the text elements. * add regtests demonstrating 'right-padding and correct alignment * remove hard-coded 'bound-details setting in New_dynamic_engraver, which prevented user override * add dynamic-text-interface with user property 'right-padding * add 'before-line-breaking callback dynamic-text-spanner::before-line-breaking which checks whether the left bound is a DynamicText; if this is true, set nested properties 'left 'attach-dir/'padding to prevent collision

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
A input/regression/dynamics-text-left-text-alignment.ly View 1 chunk +13 lines, -0 lines 0 comments Download
A input/regression/dynamics-text-right-padding.ly View 1 chunk +12 lines, -0 lines 0 comments Download
M lily/new-dynamic-engraver.cc View 1 chunk +1 line, -10 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 4 chunks +5 lines, -2 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 1
joeneeman
14 years, 4 months ago (2010-01-13 22:11:52 UTC) #1
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b